-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electrons are pixelated #121
Comments
Yes, similar to #113 -- electrons are also rendered using scenery Sprites, see ElectronsNode.ts. Assigning to @jonathanolson, since he's also investigating #113. |
I added mipmap support using the same approach that @jonathanolson used in #113, with the same scale factors and mipmapBias. See screenshot below. @jonathanolson @matthew-blackman please review. Last one to review close, if everything is OK. |
Looks good to me. Minor stylistic recommendation for matrix.rowMajor arguments to be split in rows of 3, so that it visually looks like the matrix representation, e.g.: this.matrix.rowMajor(
ELECTRON_INVERSE_SCALE, 0, position.x + ELECTRON_RADIUS,
0, ELECTRON_INVERSE_SCALE, position.y + ELECTRON_RADIUS,
0, 0, 1
); instead of this.matrix.rowMajor( ELECTRON_INVERSE_SCALE, 0, position.x + ELECTRON_RADIUS, 0,
ELECTRON_INVERSE_SCALE, position.y + ELECTRON_RADIUS, 0, 0, 1 ); |
This looks great! Nice work all. Closing. |
Good idea. I'll do that. |
Test device
MacBook Pro M1
Operating System
macOS Monterey - 12.0.1
Browser
Chrome 123.0.6312.59
As part of #103, I noticed that the electron images appear pixelated (see screenshot below). Could this be a similar issue to #113? Seeing the visual improvements to the sim from that issue being resolved, I think this is worth a similar effort.
The text was updated successfully, but these errors were encountered: