-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skater teleports after cutting specific track #239
Comments
I've created a gist with the entire console log and my attempts at inspection to create debugTrack 14 (maybe you can reproduce): https://gist.github.com/jonathanolson/2cb01de844c418bf0885 |
Not sure what is causing that. The behavior I expected is for the skater to detach from the track when it is cut, perhaps if the skater's position is being updated to the new spline coordinates before detachment, it could teleport? |
I tried reproducing this problem a few times, but could not. |
Perhaps in the next dev test, our QA team could check to see if they can get the skater to teleport by cutting tracks or deleting track points while the skater is on the track. |
@samreid I could not reproduce this issue either. @jonathanolson Do you have any more detailed steps for reproducing the issue? |
I was not able to reproduce this either, it was very hard to trigger. |
I was just able to reproduce this issue on OSX 10.9.5. It is quite difficult to reproduce. I will keep trying this method so I can develop specific instructions |
I noticed that cutting one of the higher nodes while the skater is at the point of minimum PE causes the skater to immediately hit the ground. Sometimes when I cut a higher left node immediately after the skater has passed, she will flip around to the other side of the track. Not sure if this is caused by the splitting and moving of the track or just a bug. |
It seems important that the skater detach from the track when the track is cut, so perhaps this is an acceptable side-effect (could be more complex to apply a patch-y workaround). So perhaps we should live with this problem unless we observe that it is disrupting learning? |
Agree with @samreid here. Here is another case where as long as energy is conserved there is no issue, since it is somewhat rare use case, and we are allowed to set the "rules" of this world (ie the skater leaves the track when it is cut). If we truly feel this is an issue, we could just reset the skater to the ground and clear the energy any time a track is cut, but I believe the behavior is fine as is (since energy is conserved). Good find regardless @bryo5363! |
In the console:
I'll check in debugTrack 14 for testing, but:
What happened is you could wait until the skater was to the right side of the track, then cut the upper-right control point and the skater would instantly teleport to either the ground or the (fairly far away) lower track section.
When using debugTrack with the same track info, it seems to correct itself as if it's an invalid state.
The text was updated successfully, but these errors were encountered: