Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track available bounds was null after reset all. #201

Closed
samreid opened this issue Aug 25, 2014 · 14 comments
Closed

Track available bounds was null after reset all. #201

samreid opened this issue Aug 25, 2014 · 14 comments
Assignees
Labels

Comments

@samreid
Copy link
Member

samreid commented Aug 25, 2014

Track available bounds was null after reset all.

@samreid
Copy link
Member Author

samreid commented Aug 26, 2014

Fixed above and will be ready for review in the next dev version.

@samreid samreid removed their assignment Aug 26, 2014
@samreid
Copy link
Member Author

samreid commented Aug 26, 2014

The bug exhibited by this problem was that tracks wouldn't smooth out after reset all.

@bryo5363
Copy link

@samreid can you please elaborate on this issue? I am not really sure what to look for here.

@samreid
Copy link
Member Author

samreid commented Aug 28, 2014

I created this problem using these steps:

  1. Select Playground screen
  2. create a track
  3. press reset all
  4. create a track
  5. try putting the 1st control point on top of the 3rd control point => it doesn't smooth out.

Hopefully fixed in the latest version. Let me know if you need further discussion.

@bryo5363
Copy link

@samreid after refreshing I was able to reproduce a track like this.

screen shot 2014-08-28 at 2 47 57 pm

Then the weird behavior ensues...

https://drive.google.com/file/d/0B7WUaZM7uvVKeTRHb3g5amN1MzA/edit?usp=sharing

@samreid
Copy link
Member Author

samreid commented Aug 29, 2014

Thanks for the screencast, that is very helpful!

@samreid samreid self-assigned this Aug 29, 2014
@samreid
Copy link
Member Author

samreid commented Aug 29, 2014

The latest problem may be addressed by #207.

@bryo5363
Copy link

bryo5363 commented Sep 9, 2014

This issue is still apparent on iPad @samreid

@samreid
Copy link
Member Author

samreid commented Sep 10, 2014

I could not reproduce either of the two above problems on Win8/Chrome. Can you please specify which problem you are seeing? Can you create the problem on Win8/Chrome?

@bryo5363
Copy link

screen shot 2014-09-18 at 1 53 27 pm

I was able to produce this on Safari 6.1.6 OSX 10.8.5

@bryo5363
Copy link

bryo5363 commented Oct 9, 2014

Still able to produce a track like this in Safari 9537.78.10.17.1

screen shot 2014-10-09 at 10 44 29 am

It is easy to produce tracks like this. All you need to do is keep dragging new tracks and the bounds will not be enabled.

@samreid
Copy link
Member Author

samreid commented Oct 24, 2014

I expect the above track to be somewhat rare with students, and it may be very difficult to solve, so perhaps this shouldn't prevent publication.

@ariel-phet
Copy link

Interviews suggest that students are not interested in creating these sorts of tracks. Usually, they try to make loops, so I am in agreement that it should not prevent publication, with a caveat.

@samreid, I am fine if such tracks are able to be produced, but I am not fine if the smoothing behavior goes away when reset all is pressed. I could not reproduce this issue on Win 7 chrome. Is it specific to safari, or what is going on here?

@ariel-phet ariel-phet assigned samreid and unassigned bryo5363 Oct 27, 2014
@samreid
Copy link
Member Author

samreid commented Oct 27, 2014

The primary problem for this issue (about the smoothing being broken after reset all) was solved above in 0ceb742

Closing based on @ariel-phet's remarks.

@samreid samreid closed this as completed Oct 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants