Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes the skater is facing the wrong direction on the ground #181

Closed
samreid opened this issue Aug 12, 2014 · 6 comments
Closed

Sometimes the skater is facing the wrong direction on the ground #181

samreid opened this issue Aug 12, 2014 · 6 comments
Labels
status:ready-for-review type:bug
Milestone
1.1+

Comments

@samreid
Copy link
Member

samreid commented Aug 12, 2014

image
@samreid samreid added the bug label Aug 12, 2014
@samreid samreid self-assigned this Aug 12, 2014
@samreid
Copy link
Member Author

samreid commented Aug 12, 2014

@ariel-phet said this is not critical to fix before publication.

samreid added a commit that referenced this issue Aug 15, 2014
@samreid
If traveling on the ground, face in the direction of motion, see #181
a37f6f2
@samreid
Copy link
Member Author

samreid commented Aug 15, 2014

Fixed, will be available in the next version.

@samreid samreid removed their assignment Aug 15, 2014
@orejolaphet
Copy link

@samreid I checked this bug in version 1.0.0-rc.14, and it seems for a brief moment the skater flashes the opposite direction. This doesn't seem to be an issue though. Behavior looks great.

@samreid
Copy link
Member Author

samreid commented Aug 18, 2014

I stepped through each frame, and also saw the skater face the wrong direction for one frame (using the case above). But I agree this seems acceptable (if not physically somewhat accurate). Closing.

@samreid samreid closed this as completed Aug 18, 2014
@samreid samreid mentioned this issue Sep 5, 2014
Closed
@samreid samreid reopened this Sep 5, 2014
@samreid samreid added this to the 1.1+ milestone Sep 5, 2014
@samreid samreid mentioned this issue Sep 9, 2014
Closed
7 tasks
@orejolaphet
Copy link

@samreid This bug is still present in 1.0.0-dev.60 on Chrome win 7. Doesn't seem very like a huge issue. Visible for a brief moment with slow motion selected, and checking frame by frame occurs for only one frame.

@samreid samreid mentioned this issue Sep 29, 2014
Closed
13 tasks
@samreid samreid mentioned this issue Oct 8, 2014
Closed
15 tasks
@orejolaphet
Copy link

@samreid Verified fixed in 1.0.0-dev.78 👍

@bryo5363 bryo5363 closed this as completed Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready-for-review type:bug
Projects
None yet
Milestone
1.1+
Development

No branches or pull requests
3 participants
@samreid @orejolaphet @bryo5363