Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage resetting for mutable material and gravity Property instances #267

Closed
samreid opened this issue Jul 17, 2024 · 2 comments
Closed

Manage resetting for mutable material and gravity Property instances #267

samreid opened this issue Jul 17, 2024 · 2 comments
Assignees
@zepumph
Labels
status:ready-for-review

Comments

@samreid
Copy link
Member

samreid commented Jul 17, 2024

Side issue for #256, which is currently in a branch #258
@samreid samreid self-assigned this Jul 17, 2024
samreid added a commit that referenced this issue Jul 17, 2024
@samreid
Move TODOs, see #267 and #256
2b32915
samreid added a commit that referenced this issue Jul 19, 2024
@samreid
Reset densityProperty and gravityProperty, see #267
2e0ac17
@samreid
Copy link
Member Author

samreid commented Jul 19, 2024

Implemented above. @zepumph can you please review as part of #256 review?

@samreid samreid assigned zepumph and unassigned samreid Jul 19, 2024
@zepumph
Copy link
Member

zepumph commented Jul 25, 2024

This is perfect. I don't believe any non custom materials will need resetting. Closing

@zepumph zepumph closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph