Move TODOs, see #267 and #256

phetsims · Jul 17, 2024 · 2b32915 · 2b32915
1 parent d4f8262
commit 2b32915
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/js/common/model/Gravity.ts b/js/common/model/Gravity.ts
@@ -53,7 +53,7 @@ export default class Gravity extends PhetioObject implements HasValueProperty {
 
     this.nameProperty = options.nameProperty;
 
-    // TODO: Make sure gravityValueProperty is reset, see https://github.com/phetsims/density-buoyancy-common/issues/256
+    // TODO: Make sure gravityValueProperty is reset, see https://github.com/phetsims/density-buoyancy-common/issues/267
     this.gravityValueProperty = new NumberProperty( options.value, {
       // TODO: Instrumentation, see https://github.com/phetsims/density-buoyancy-common/issues/256
       // tandem: options.tandem

diff --git a/js/common/model/MappedWrappedProperty.ts b/js/common/model/MappedWrappedProperty.ts
@@ -22,7 +22,7 @@ export type HasValueProperty = {
   valueProperty: TProperty<number>;
 };
 
-// TODO: reset these, https://github.com/phetsims/density-buoyancy-common/issues/256
+// TODO: reset these, https://github.com/phetsims/density-buoyancy-common/issues/267
 export default abstract class MappedWrappedProperty<T extends HasValueProperty> extends Property<T> {
   protected readonly dynamicValueProperty: TReadOnlyProperty<number>;
   public readonly customValue: T;

diff --git a/js/common/model/Material.ts b/js/common/model/Material.ts
@@ -57,7 +57,7 @@ export type MaterialOptions = SelfOptions & StrictOmit<PhetioObjectOptions, 'tan
 
 const MATERIALS_TANDEM = Tandem.GLOBAL_MODEL.createTandem( 'materials' );
 
-// TODO: Resetting all Property instances that can/should be, https://github.com/phetsims/density-buoyancy-common/issues/256
+// TODO: Resetting all Property instances that can/should be, https://github.com/phetsims/density-buoyancy-common/issues/267
 // TODO: Material should wire up color properties https://github.com/phetsims/density-buoyancy-common/issues/256
 // TODO: Material only needs one color Property, https://github.com/phetsims/density-buoyancy-common/issues/256
 // TODO: Material should know its density range https://github.com/phetsims/density-buoyancy-common/issues/256
@@ -184,8 +184,8 @@ export default class Material extends PhetioObject implements HasValueProperty {
 
   /**
    * TODO: a couple thoughts. https://github.com/phetsims/density-buoyancy-common/issues/256
-   *       1. could this be solved is MaterialProperty.colorProperty was a dynamic property, then these usages would just link to that to update the THREE mesh.
-   *       2. At the very leas, move this to a prototype method on MaterialProperty.
+   *  1. could this be solved is MaterialProperty.colorProperty was a dynamic property, then these usages would just link to that to update the THREE mesh.
+   *  2. At the very least, move this to a prototype method on MaterialProperty.
    *
    * Keep a material's color and opacity to match the liquid color from a given Property<Material>
    *