Review instrumentation of colorProfile

[arouinfar]

In phetsims/buoyancy#51 (comment) the devs asked:

All the colors listed in Buoyancy and Density are phetioReadOnly:true. Why is this valuable to have? Should they be uninstrumented?

The relevant paper trail is in #65 and it appears that the instrumented ColorProperties may be required for State.

I'd like to review global.view.colors for all sims in the suite and decide:

• Should any additional colors be instrumented?
• Are there any ColorProperties that would benefit from being phetioReadOnly: false?

[arouinfar]

The mystery fluid colors still use the old "Density A", etc. naming scheme and should likely be updated to the new "Fluid A" language introduced in #248

Edit: I reported this in #265.

[arouinfar]

Here is the full list of the instrumented colors. All 3 density-buoyancy-common sims are the same, even though these colors don't necessarily appear in all sims. In general, these colors correspond to the fluids in the pool and the materials inside the bottle, which seem like useful things to let clients control.

I'd like to wait for #265 to wrap up before working on this issue.

[arouinfar]

The design requests in #265 have wrapped up, but I think it makes the most sense to review this along with the materials over in #250.

[arouinfar]

We discussed this in today's design meeting over in #268 (comment).

I'll leave this on hold until #268 is completed.

[AgustinVallejo]

#268 Is almost done, and no longer holding this one.

[arouinfar]

Density does not require any instrumentation of the color profile, as the Mystery blocks all have a colorProperty as a part of the customMaterial.

Buoyancy and Buoyancy: Basics both have the same set of instrumented colors:

None of these colors need to be customizable, so I recommend uninstrumenting them. In #268 (comment), we noted that customizing fluid colors, in particular, could be problematic.

It would be nice to customize the colors of the mystery materials (T-Y) that don't have a textured appearance. Can we instrument those colors?

To summarize:

• No changes needed for Density

• For Buoyancy & Buoyancy: Basics: Uninstrument all currently instrumented colors.
• For Buoyancy only: Instrument the colors of mystery materials T-Y

[samreid]

In the commits, I uninstrumented all ColorProperties, then added read/write instrumentation for the mysteries T-Y. In studio I was able to customize the color, and I saw it was preserved in Test. Please review.

[arouinfar]

Looks good on main, thanks @samreid! Closing.