Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mystery fluids should be called 'Fluid A' rather than 'Density A' #248

Closed
arouinfar opened this issue Jul 3, 2024 · 3 comments
Closed

Mystery fluids should be called 'Fluid A' rather than 'Density A' #248

arouinfar opened this issue Jul 3, 2024 · 3 comments
Assignees
@arouinfar
Labels
dev:help-wanted Extra attention is needed dev:phet-io status:ready-for-review

Comments

@arouinfar
Copy link

arouinfar commented Jul 3, 2024 •
edited
Loading

Related to phetsims/buoyancy#51

During today's design meeting with @DianaTavares @AgustinVallejo @samreid @zepumph, we decided to call the mystery fluids 'Fluid A', etc. They are currently named 'Density A' etc.

image image

We'll need to change string in the ListBox, associated phetioID, and string key to use the 'fluid' language.
AgustinVallejo added a commit that referenced this issue Jul 4, 2024
@AgustinVallejo
Changing mystery Density for Fluid, see #248
6e760c7
AgustinVallejo added a commit to phetsims/babel that referenced this issue Jul 4, 2024
@AgustinVallejo
Changing mystery Density for Fluid, see phetsims/density-buoyancy-com…
a6c313a 
…mon#248
@AgustinVallejo
Copy link
Contributor

Pushing this change. What's left is changing the string keys, as I would like to do it with a more experienced developer to avoid translation mishaps.

@AgustinVallejo AgustinVallejo added the dev:help-wanted Extra attention is needed label Jul 4, 2024
@AgustinVallejo AgustinVallejo mentioned this issue Jul 5, 2024
Closed
7 tasks
@AgustinVallejo
Copy link
Contributor

Moving that string key part to #183. Assigning back to @arouinfar for review.

@arouinfar
Copy link
Author

Thanks @AgustinVallejo! Looks good in main, closing.

This was referenced Jul 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
dev:help-wanted Extra attention is needed dev:phet-io status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samreid @zepumph @arouinfar @AgustinVallejo