Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dilate touch areas on charge NumberControls #89

Closed
arouinfar opened this issue Nov 28, 2018 · 6 comments
Closed

Dilate touch areas on charge NumberControls #89

arouinfar opened this issue Nov 28, 2018 · 6 comments
Assignees

Comments

@arouinfar
Copy link
Contributor

For phetsims/qa#221

@kathy-phet commented that the charge controls were a bit tricky to use on mobile, and recommended dilating the touch areas a bit.

There's plenty of room, so I think something like this would be helpful @mbarlow12.
screen shot 2018-11-28 at 8 38 30 am

@kellywurtz
Copy link

On rc.6, looks like the slider touch area size increased, but not the arrows. Looking on Windows 10 Chrome.

image

@arouinfar
Copy link
Contributor Author

Good catch @kellywurtz. @kathy-phet's original concern was more with the tweakers, so it'd be good to fix @mbarlow12.

@arouinfar
Copy link
Contributor Author

Tagging phetsims/qa#235 so this issue shows up in the list.

@mbarlow12 I don't see any recent commits here, so not sure if #89 (comment) was addressed or not.

@kathy-phet
Copy link

kathy-phet commented Dec 19, 2018

phettest looks smaller than the above screenshot, so something looks like it was reverted. Do please increase both tweekers and thumb.
image

@kathy-phet
Copy link

The above was seen on phettest. Amy thought that perhaps the change Kelly saw was not done on master? @mbarlow12 - please make sure master has any of the fixes too.

@KatieWoe
Copy link
Contributor

This looks good 1.0.0-rc.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants