Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC test: Coulomb's Law 1.0.0-rc.7 #242

Closed
3 tasks
mbarlow12 opened this issue Dec 20, 2018 · 6 comments
Closed
3 tasks

RC test: Coulomb's Law 1.0.0-rc.7 #242

mbarlow12 opened this issue Dec 20, 2018 · 6 comments

Comments

@mbarlow12
Copy link

@KatieWoe, @arouinfar, @jessegreenberg, @ariel-phet coulombs-law/1.0.0-rc.8 is ready for a final spot RC check. Document issues in https://github.com/phetsims/coulombs-law/issues and link to this issue.

There are a few issues discovered from the last RC that won't be addressed prior to this publication. They are noted below.

Assigning @ariel-phet for prioritization.

General RC Test

What to Test

  • Click every single button.
  • Play with the sim normally.
  • Try to break the sim.
  • Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
  • Complete the test matrix.
  • Check this LoL spreadsheet and notify AR if it not there.

Issues to Verify

These issues should have the "status:fixed-pending-testing" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed.

iOS crashing is apparently no longer an issue, but we should still check to ensure it doesn't arise again.

The following issues won't be addressed prior to publication.

Link(s)


Accessibility (a11y) RC Test

What to Test

  • Specific instructions can be found below.
  • Make sure the a11y feature doesn't negatively affect the sim in any way.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
    • Test all keyboard navigation inputs (if applicable).

Link(s)

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended.


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@KatieWoe
Copy link
Contributor

KatieWoe commented Dec 20, 2018

@mbarlow12 how does this list look for platforms?

  • Win 10 chrome Full
  • Win 10 firefox
  • Win 10 edge Full

  • Mac 10.14 chrome
  • Mac 10.14 firefox Full
  • Mac 10.14 safari Full

  • iOS 12 Full
  • iOS 10

  • Chrome OS

  • Win 7 IE Full
  • Win 7 chrome
  • Mac 10.11 safari
  • Mac 10.11 firefox

@kellywurtz
Copy link

I'm checking platforms off in the list above if they pass all RC test measures and pre-existing issue checks, EXCEPT for this (quite problematic) bug Laura found above (phetsims/coulombs-law#97). In other words, a check means that new bug is there, but everything else is performing perfectly fine.

@mbarlow12
Copy link
Author

New RC version at:
https://phet-dev.colorado.edu/html/coulombs-law/1.0.0-rc.8/phet/coulombs-law_en_phet.html

Apologies for the issue; single line comment prevented redrawing the vectors and force values.

@KatieWoe
Copy link
Contributor

QA Testers: Please test the link above.

@mbarlow12
Copy link
Author

We can also close this and use #243.

@ghost ghost removed the priority:1-top label Dec 20, 2018
@ghost
Copy link

ghost commented Dec 20, 2018

Closing.

@ghost ghost closed this as completed Dec 20, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants