Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Inelastic collisions #139

Closed
brandonLi8 opened this issue Aug 4, 2020 · 1 comment
Closed

Issues with Inelastic collisions #139

brandonLi8 opened this issue Aug 4, 2020 · 1 comment
Assignees
Labels
type:bug Something isn't working

Comments

@brandonLi8
Copy link
Contributor

For phetsims/qa#524.

So far, perfectly elastic collisions are working well and I haven't found any bugs (testing on master). I have found a few cases that were incorrect when the elasticity wasn't 100%, particularly when a stack of balls collides with the border.

Example:

*

@brandonLi8 brandonLi8 added the type:bug Something isn't working label Aug 4, 2020
@brandonLi8 brandonLi8 self-assigned this Aug 4, 2020
brandonLi8 added a commit that referenced this issue Aug 4, 2020
brandonLi8 added a commit that referenced this issue Aug 4, 2020
@brandonLi8
Copy link
Contributor Author

This should be fixed in the commits above. I tested the exact same collision in the commit above and found no errors. I also tested all the other scenarios that I found that were broken and they all work fine. This could introduce new bugs. Closing.

brandonLi8 added a commit that referenced this issue Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant