Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Test: Collision Lab 1.0.0-dev.32 #524

Closed
5 tasks
brandonLi8 opened this issue Jul 31, 2020 · 5 comments
Closed
5 tasks

Dev Test: Collision Lab 1.0.0-dev.32 #524

brandonLi8 opened this issue Jul 31, 2020 · 5 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@brandonLi8
Copy link

brandonLi8 commented Jul 31, 2020

@arouinfar @ariel-phet, collision-lab/1.0.0-dev.32 is ready for dev testing (for the prototype). The goal is to release the prototype by the end of the week.

Document issues in https://github.com/phetsims/collision-lab/issues and link to this issue.

It was also decided that @arouinfar and @ariel-phet will be doing the testing, so I'm assigning to them.

General Dev Test

What to Test

  • Click every single button.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Try to include browser version numbers
  • If there is a console available, check for errors and include them in the Problem Description.
  • Run through the string tests on at least one platform, especially if it is about to go to rc.
  • Check the Game Up harness on one platform.

Focus and Special Instructions

Focus should be on performance of the simulation and collisions (and if its “acceptable”) on potentially slower devices.

General Dev Test Platforms

  • Latest macOS, Chrome and Safari
  • Latest iOS, Safari
  • Windows 10, all browsers (IE dropped)
  • Latest Chrome OS, Chrome

Issues to Verify

These issues should have either use the labels "status:ready-for-qa" or "status:ready-for-review." If it is ready for
QA then close the issue if fixed. If ready for review then leave open and assign back to the developer.

Link(s)


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@brandonLi8
Copy link
Author

It was requested to publish a new dev link for the fixes implemented for the issues above: https://phet-dev.colorado.edu/html/collision-lab/1.0.0-dev.33/phet/collision-lab_en_phet.html. I changed the links in the original comment.

@ariel-phet
Copy link
Contributor

ariel-phet commented Aug 4, 2020

For a performance test I am trying the explore 2D screen with 4 balls, grid active, every option checked, more data open, and momenta diagram open.

  • Performance looks great on my desktop (Fast Win 10 machine)

  • I also checked on my phone (which is a fairly fast Android but a couple years old) - performance also looked good

  • Checked on iPad Air 2, iOS 13.6, performance also looks very good.

@ariel-phet
Copy link
Contributor

I looked at a bunch of physics tests, everything seems to be correct

@ariel-phet ariel-phet assigned brandonLi8 and unassigned ariel-phet and arouinfar Aug 4, 2020
@ariel-phet
Copy link
Contributor

@brandonLi8 I think we can call this dev test complete. Once you have addressed the critical issues, lets do another brief dev test, assign directly to me.

@brandonLi8
Copy link
Author

Critical issues addressed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

3 participants