Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragged Voltmeter resets draggingProbesWithBodyProperty in launched standard wrapper #972

Closed
samreid opened this issue Feb 18, 2023 · 4 comments
Closed

Dragged Voltmeter resets draggingProbesWithBodyProperty in launched standard wrapper #972

samreid opened this issue Feb 18, 2023 · 4 comments
Assignees
@matthew-blackman
Milestone
Full initial PhET...

Comments

@samreid
Copy link
Member

samreid commented Feb 18, 2023

Discovered in #968 and phetsims/qa#900. Dragged Voltmeter resets draggingProbesWithBodyProperty in launched standard wrapper. The effect is that the probes jump to the sides of the voltmeter body on drag even if they were attached to a circuit.
@samreid samreid self-assigned this Feb 18, 2023
@samreid
Copy link
Member Author

samreid commented Feb 18, 2023

Before starting, I noticed there are many changes to the PhET-iO API files. I'll update those first.

samreid added a commit that referenced this issue Feb 18, 2023
@samreid
Instrument draggingProbesWithBodyProperty, see #972
f8b1297
@samreid
Copy link
Member Author

samreid commented Feb 18, 2023

Fixed. @arouinfar and @matthew-blackman is the name draggingProbesWithBodyProperty ok? Please close if acceptable.

@samreid samreid assigned arouinfar and matthew-blackman and unassigned samreid Feb 18, 2023
@samreid samreid mentioned this issue Feb 18, 2023
Closed
@matthew-blackman
Copy link

Since draggingProbesWithBodyProperty is a boolean, @zepumph suggested to add the 'is' prefix to the class attribute as well as the PhET-iO ID.

matthew-blackman pushed a commit that referenced this issue Feb 20, 2023
@UniverseAndMore
Rename 'draggingProbesWithBodyProperty' to 'isDraggingProbesWithBodyP…
75fa275 
…roperty' in vars and PhET-iO IDs - see #972
@matthew-blackman
Copy link

All variables and PhET-iO ids are now appropriately named. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthew-blackman matthew-blackman

Labels
None yet
Projects
None yet
Milestone
Full initial PhET-iO release: DC
Development

No branches or pull requests
3 participants
@samreid @arouinfar @matthew-blackman