Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launched sim fails to load when voltmeter is used in Studio #968

Closed
Nancy-Salpepi opened this issue Feb 17, 2023 · 3 comments
Closed

Launched sim fails to load when voltmeter is used in Studio #968

Nancy-Salpepi opened this issue Feb 17, 2023 · 3 comments
Labels
status:ready-for-review type:bug
Milestone
Full initial PhET...

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air

Operating System
13.1

Browser
Safari and Chrome

Problem description
For phetsims/qa#900, in Studio, when a voltmeter is hooked up to a circuit, the standard PhET-iO wrapper doesn't load.

Steps to reproduce

  1. Create a simple circuit in studio on either screen
  2. Attach the voltmeter
  3. Launch the standard PhET-iO wrapper

**Visual
Screenshot 2023-02-16 at 7 56 24 PM

Screenshot 2023-02-16 at 7 52 58 PM

Screenshot 2023-02-16 at 7 42 34 PM
@samreid samreid mentioned this issue Feb 18, 2023
Closed
samreid added a commit that referenced this issue Feb 18, 2023
@samreid
Return null from VoltageConnectionIO.fromStateObject, see #968
73d930b
@samreid
Copy link
Member

samreid commented Feb 18, 2023

Fixed, and ready for testing in master. Please be aware of related issue #972

@samreid samreid assigned Nancy-Salpepi and unassigned samreid Feb 18, 2023
@Nancy-Salpepi
Copy link
Author

This looks fixed in master.

@Nancy-Salpepi Nancy-Salpepi removed their assignment Feb 20, 2023
@matthew-blackman
Copy link

This issue has been reviewed and tested. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready-for-review type:bug
Projects
None yet
Milestone
Full initial PhET-iO release: DC
Development

No branches or pull requests
4 participants
@samreid @arouinfar @Nancy-Salpepi @matthew-blackman