Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to drag fuse slider to end of slider #662

Closed
KatieWoe opened this issue Feb 10, 2021 · 5 comments
Closed

Unable to drag fuse slider to end of slider #662

KatieWoe opened this issue Feb 10, 2021 · 5 comments
Assignees

Comments

@KatieWoe
Copy link
Contributor

Test device
Lovelace
Operating System
ChromeOS
Browser
Chrome
Problem description
For phetsims/qa#605.
When dragging the slider it increments by 1.0, but the arrows go by .1. This means that you can't drag the fuse to it's minimum setting. It stops at 1.0, but it's actual minimum is .5.
This was not an issue in the published version, which seems to be because the published sim increments this value by .5.
Steps to reproduce

  1. Drag fuse out
  2. Select fuse and use slider to try and minimize it's current rating
  3. Use arrows to fully minimize the rating

Visuals
oneorpointfive

@arouinfar arouinfar removed their assignment Feb 10, 2021
@arouinfar
Copy link
Contributor

@samreid let's change the constrainValue to 0.5

@samreid
Copy link
Member

samreid commented Feb 13, 2021

In the commit, I round constrainValue to 0.5 instead of 1. It seems OK on my side. @arouinfar or @KatieWoe can you please review in master? If it is OK, please reassign to me so I can cherry pick into the RC.

@arouinfar
Copy link
Contributor

Looks good @samreid.

@arouinfar arouinfar assigned samreid and unassigned arouinfar and KatieWoe Feb 15, 2021
samreid added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Feb 16, 2021
samreid added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Feb 16, 2021
@samreid
Copy link
Member

samreid commented Feb 17, 2021

This is ready for spot checking in the deployments listed for phetsims/qa#610, please close if it seems correct in RC.2.

@KatieWoe
Copy link
Contributor Author

Looks good in rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants