-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC Test: Circuit Construction Kit: DC & DC "Virtual Lab" 1.2.0-rc.1 #605
Comments
I set priority to "high" and moved it above "Gravity and Orbits" in the Project Board, please adjust as necessary. |
@jessegreenberg said there is a joist bug that affects the home screen. We would likely invalidate this RC and take new SHAs once that's corrected. |
Sorry @samreid, the regression identified in phetsims/joist#658 (comment) made it to this RC. This reverting commit in joist should be cherry-picked into the joist code for this RC. phetsims/joist@d0be22a |
@KatieWoe if you have a chance to start testing before I publish new versions, I think that's OK. Let's just consider phetsims/joist@d0be22a as something to be cherry-picked before publication. |
Noting that this sim should be added to the LoL spreadsheet when it is ready. |
These sims have already been delivered to LoL. Since the client uses the "latest" version of the sim, they won't need to manually update anything. The changes are not significant enough to warrant new icons/descriptions. |
QA is done. |
Thanks, I reviewed the opened issues and will continue there. Nice discoveries and thanks! |
@arouinfar @kathy-phet @KatieWoe, circuit-construction-kit-dc/1.2.0-rc.1 and circuit-construction-kit-dc-virtual-lab/1.2.0-rc.1 are ready for RC testing.
@kathy-phet said:
Document issues in https://github.com/phetsims/circuit-construction-kit-common/issues and link to this
issue.
Prior dev testing completed in #587
The publication issue is phetsims/circuit-construction-kit-common#616
Assigning to @kathy-phet or @KatieWoe for prioritization.
General RC Test
What to Test
for a list of query parameters.)
spreadsheet and notify AR or AM if it not there.
there is a problem.
Focus and Special Instructions
[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested,
list them here. Any behaviors you want QA to pay special attention to should be listed here.]
Issues to Verify
These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.
Link(s)
CCK DC
CCK DC Virtual Lab (just needs a spot check, since it is 99% same as CCK DC)
Accessibility (a11y) RC Test
What to Test
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel controls. Please test magnfication and make sure
it is working as intended and well with the use cases of the simulation. Due to the way screen readers handle user input, magnification is NOT expected to
work while using a screen reader so there is no need to test this case.
Final Requests
issue in website to ask if PhET research page links need updating. Please assign
to @terracoda and @emily-phet.
FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.
How should I format my issue?
Here's a template for making issues:
Who should I assign?
We typically assign the developer who opened the issue in the QA repository.
My question isn't in here... What should I do?
You should:
The text was updated successfully, but these errors were encountered: