Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address TODOs #531

Closed
samreid opened this issue Oct 18, 2019 · 2 comments
Closed

Address TODOs #531

samreid opened this issue Oct 18, 2019 · 2 comments
Assignees
@samreid
Milestone
AC 1.0

Comments

@samreid
Copy link
Member

samreid commented Oct 18, 2019

Currently at 82 TODOs
@samreid samreid self-assigned this Oct 18, 2019
samreid added a commit that referenced this issue Oct 18, 2019
@samreid
Address TODOs, see #531
e064164
samreid added a commit that referenced this issue Oct 18, 2019
@samreid
Use createVertexPairArray, see #531
6a1204a
samreid added a commit that referenced this issue Oct 19, 2019
@samreid
Add FUSE_LENGTH, see #531
8cd4c0b
@samreid samreid mentioned this issue Oct 21, 2019
Closed
samreid added a commit that referenced this issue Nov 4, 2019
@samreid
Clean up disposeFromGroup, see #531
bc1bdc7
samreid added a commit that referenced this issue Nov 4, 2019
@samreid
Remove unused method, see #531
ab4827d
samreid added a commit that referenced this issue Nov 4, 2019
@samreid
Inline createVertices, see #531
90318c6
samreid added a commit that referenced this issue Nov 4, 2019
@samreid
Remove the explicit vertexGroup.clear, see #531
b0f1b0b
samreid added a commit that referenced this issue Nov 4, 2019
@samreid
Don't require vertex to be in the vertexGroup for search, see #531
0e9cfe7
samreid added a commit that referenced this issue Nov 4, 2019
@samreid
Remove custom serialization code, see #531
dbeea7f
samreid added a commit to phetsims/circuit-construction-kit-ac that referenced this issue Nov 4, 2019
@samreid
Remove custom serialization code, see phetsims/circuit-construction-k…
1b359af 
…it-common#531
samreid added a commit that referenced this issue Nov 4, 2019
@samreid
Minor cleanup and organize TODOs, see #531
efe078e
samreid added a commit that referenced this issue Nov 5, 2019
@samreid
Fix incorrect usage of merge in tests, see #531
341244d
samreid added a commit that referenced this issue Nov 5, 2019
@samreid
Factor out elements, see #531
caad9ac
samreid added a commit that referenced this issue Nov 5, 2019
@samreid
Cleanup in DynamicCircuit, see #531
9858fb1
samreid added a commit that referenced this issue Nov 5, 2019
@samreid
Update TODOs, see #531
87c9a4e
samreid added a commit that referenced this issue Nov 5, 2019
@samreid
Docs and clean up TODOs, see #531
bc5d36a
samreid added a commit that referenced this issue Nov 5, 2019
@samreid
Remove DynamicCircuit battery argument, see #531
8a6419e
samreid added a commit that referenced this issue Nov 5, 2019
@samreid
Rename variables, see #531
a86c1ff
samreid added a commit that referenced this issue Nov 5, 2019
@samreid
Cleanup and docs, see #531
62ec2b2
samreid added a commit that referenced this issue Nov 5, 2019
@samreid
Convert usedNodes to array, see #531
165631e
samreid added a commit that referenced this issue Nov 5, 2019
@samreid
Clean up DynamicCapacitor and DynamicInductor, see #531
ef0e5fb
samreid added a commit that referenced this issue Nov 5, 2019
@samreid
Remove unused variable, see #531
90b7758
samreid added a commit that referenced this issue Nov 6, 2019
@samreid
Eliminate toMNAResult, see #531
cc025ed
samreid added a commit that referenced this issue Nov 6, 2019
@samreid
Minor cleanup, see #531
0a9dde0
samreid added a commit that referenced this issue Nov 6, 2019
@samreid
Remove unused class, see #531
dcf7af3
samreid added a commit that referenced this issue Nov 6, 2019
@samreid
Docs updates, see #531
c7822a5
samreid added a commit that referenced this issue Nov 6, 2019
@samreid
Cleanup and use final state, see #531
22dfbb5
samreid added a commit that referenced this issue Nov 6, 2019
@samreid
Normalize companion elements, see #531
4b541a4
samreid added a commit that referenced this issue Nov 24, 2019
@samreid
Rename variables, see #531
4c38e2e
samreid added a commit that referenced this issue Nov 24, 2019
@samreid
Update docs, see #531
339bd4d
samreid added a commit that referenced this issue Nov 24, 2019
@samreid
Update TODOs, see #531
01a2c2c
@samreid
Copy link
Member Author

samreid commented Nov 27, 2019

We are down to 30 TODOs, and I've marked several as pertaining to phet-io or black-box-study. Others have related issues.

samreid added a commit that referenced this issue Dec 9, 2019
@samreid
Use CCKCRoundPushButton in TrashButton, see #531
53924c1
samreid added a commit that referenced this issue Dec 9, 2019
@samreid
Use RoundPushButton interface, see #531
fdc0bad
samreid added a commit that referenced this issue Dec 9, 2019
@samreid
Update TODOs, see #531
ae9550a
samreid added a commit that referenced this issue Dec 9, 2019
@samreid
Rename capacitor=>dynamicCircuitCapacitor and same for inductor, see #…
7b50ad5 
…531
samreid added a commit that referenced this issue Dec 9, 2019
@samreid
Update docs and variable names, see #531
e6ed458
samreid added a commit that referenced this issue Jan 14, 2020
@samreid
Clean up TODOs, see #531
79592f6
samreid added a commit that referenced this issue Jan 14, 2020
@samreid
Specify isMetallic before super call, see #531
0b2d969
samreid added a commit that referenced this issue Jan 15, 2020
@samreid
Improve API for creating household item enumeration values, see #531
67ce0d3
samreid added a commit that referenced this issue Jan 15, 2020
@samreid
Remove completed TODO, see #531
93548fc
samreid added a commit that referenced this issue Jan 15, 2020
@samreid
Specify view offset in the enumeration values, see #531
709eb8a
@samreid samreid removed their assignment Jun 11, 2020
samreid added a commit that referenced this issue Sep 10, 2020
@samreid
Remove unused instance variable, see #531
416b443
@samreid samreid self-assigned this Sep 10, 2020
samreid added a commit that referenced this issue Oct 20, 2020
@samreid
Remove credits from common main, see #531
3e49585
samreid added a commit that referenced this issue Oct 20, 2020
@samreid
Refine TODO, see #531
83a2ccd
@samreid samreid added this to the AC 1.0 milestone Nov 17, 2020
samreid added a commit that referenced this issue Dec 15, 2020
@samreid
Update TODO to make more searchable, see #531
b285599
samreid added a commit that referenced this issue Dec 15, 2020
@samreid
Revert "Update TODO to make more searchable, see #531"
fe17aa9 
This reverts commit b285599
samreid added a commit that referenced this issue Dec 22, 2020
@samreid
Normalize TODO syntax, see #531
8182a58
samreid added a commit that referenced this issue Dec 22, 2020
@samreid
Pass options through to AmmeterNode, see #531
25a5438
samreid added a commit that referenced this issue Dec 22, 2020
@samreid
Remove unnecessary TODO, see #531
8089139
samreid added a commit to phetsims/circuit-construction-kit-ac that referenced this issue Dec 22, 2020
@samreid
Remove unnecessary TODO, see phetsims/circuit-construction-kit-common…
6d87685 
…#531
samreid added a commit to phetsims/circuit-construction-kit-ac that referenced this issue Dec 22, 2020
@samreid
Adopt credits from DC, see phetsims/circuit-construction-kit-common#531
3ee9697
samreid added a commit to phetsims/circuit-construction-kit-ac that referenced this issue Dec 22, 2020
@samreid
Refer to common documentation, see phetsims/circuit-construction-kit-…
c53100b 
…common#531
@samreid
Copy link
Member Author

samreid commented Dec 22, 2020

All TODOs that pertain to this release have been addressed or promoted to issues. Remaining TODOs are marked like "black box study" or "phet-io". Therefore, I think we should close this issue. When we work on the black-box-study or phet-io, we can open a side issue for those TODOs.

@samreid samreid closed this as completed Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
None yet
Projects
None yet
Milestone
AC 1.0
Development

No branches or pull requests
1 participant
@samreid