Specify isMetallic before super call, see #531

phetsims · Jan 14, 2020 · 0b2d969 · 0b2d969
1 parent 79592f6
commit 0b2d969
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/js/model/Resistor.js b/js/model/Resistor.js
@@ -46,16 +46,17 @@ define( require => {
       // validate resistor type
       validate( resistorType, { valueType: Resistor.ResistorType } );
 
+      // @public (read-only)
+      assert && assert( !options.hasOwnProperty( 'isMetallic' ), 'isMetallic is given by the resistorType' );
+      options.isMetallic = resistorType.isMetallic;
+
       super( startVertex, endVertex, options.resistorLength, tandem, options );
 
       // @public (read-only) {Resistor.ResistorType} indicates one of ResistorType values
       this.resistorType = resistorType;
 
       assert && assert( typeof this.resistorType.isMetallic === 'boolean' );
 
-      // @public (read-only) // TODO: is this correct?  Is it necessary?
-      options.isMetallic = this.resistorType.isMetallic;
-
       // @public {Property.<number>} the resistance in ohms
       this.resistanceProperty = new NumberProperty( resistorType.defaultResistance, {
         tandem: tandem.createTandem( 'resistanceProperty' ),