-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User suggestion: standardize schematic components #429
Comments
@oliver-phet Iooking at the user's link, we are using standard circuit symbols. Perhaps their concern is that we are using the American standard for resistors? The resistor symbol we are using is ANSI/IEEE, and the IEC (international standard) is somewhat different.
I don't think this is something we are likely to change. We could potentially have an IEEE/IEC radio option in the Options menu, similar to what we did for dipole conventions in MolPol: |
I just replied to the user, and I'll update once I hear back. |
A similar request received into phethelp:
|
Another reply from the original user:
|
Co-assigning @ariel-phet since this might be a good task for Isam. |
1/9/20 design meeting
|
Self-unassigning, please reassign me when the table of remaining components is ready. |
@samreid @ariel-phet it looks like these are the primary differences in the IEEE and IEC standards.
It seems like the coil-like inductor is a deprecated symbol, and IEEE and IEC both use the symbol currently in master. Both standards are behind a paywall, but CU has access to the IEEE standards. I've uploaded a copy of the IEEE standards to the CCK sim design folder. |
@ariel-phet or @kathy-phet or @arouinfar is this feature (query parameter and in-sim option) important for next week's dev release? |
No - its not a priority. |
Another email received 3/10/2020:
|
At today's design meeting, we agreed to go ahead with this. Let's do it as a cherry-pick maintenance release. |
The proposed fix is in master, @arouinfar can you please test and verify? I'm also seeing some layout issues in the carousel in master--we will make sure those don't affect the branch. |
@samreid the schematics, Options dialog, and query parameter are all looking good in master.
The carousel is looking pretty wacky right now. I'm seeing lots of holes. Should you publish an rc version on the 1.2 branch to verify before proceeding with the MR? (Or maybe just a dev version if you can do it on the 1.2 branch.) |
Yes, we'll publish an RC for the MR. |
@oliver-phet can you forward me the user's email so I can let them know when we publish the maintenance release? |
In phetsims/phetmarks#48 @jessegreenberg remarked that he is in the process of making a maintenance release--I'll need to coordinate with him. |
User email forwarded. |
Here's an RC for "DC": https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.2.1-rc.1/phet/circuit-construction-kit-dc_en_phet.html @arouinfar can you please test? If they seem good, I'll run a production release. |
@samreid looks good! |
Deployed: https://phet.colorado.edu/sims/html/circuit-construction-kit-dc/latest/circuit-construction-kit-dc_en.html Deployed: https://phet.colorado.edu/sims/html/circuit-construction-kit-dc-virtual-lab/latest/circuit-construction-kit-dc-virtual-lab_en.html @arouinfar does any metadata need to be changed? |
Everything's looking good and there wasn't any metadata to update. AP's also tweeted about the new feature a few times too. |
The text was updated successfully, but these errors were encountered: