Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User suggestion: standardize schematic components #429

Closed
Tracked by #9
oliver-phet opened this issue Nov 8, 2017 · 41 comments
Closed
Tracked by #9

User suggestion: standardize schematic components #429

oliver-phet opened this issue Nov 8, 2017 · 41 comments

Comments

@oliver-phet
Copy link

Delighted to see the circuit builder released on the PhET app, we have this on every school iPad - hundreds of them!

One tiny request please, that might be quite easy to add. We are based in the U.K. We, and virtually the whole world, use the IET (internationally agreed) standards for circuit symbols. As the app doesn't use very many, it should be easy to add a setting where you can choose between US symbols, or IET ones.

Details here... https://en.m.wikipedia.org/wiki/Electronic_symbol

The problem for us is that pupils already have to try hard to learn the symbols they need to know, to have to learn an entirely different set of symbols is a little unfair.

Thank you, though, for an incredible app that just keeps getting better!

@arouinfar
Copy link
Contributor

@oliver-phet Iooking at the user's link, we are using standard circuit symbols. Perhaps their concern is that we are using the American standard for resistors? The resistor symbol we are using is ANSI/IEEE, and the IEC (international standard) is somewhat different.

CCK Electronic Symbols
image image image image image

I don't think this is something we are likely to change. We could potentially have an IEEE/IEC radio option in the Options menu, similar to what we did for dipole conventions in MolPol:

image

@oliver-phet
Copy link
Author

I just replied to the user, and I'll update once I hear back.

@oliver-phet
Copy link
Author

A similar request received into phethelp:

This is not a real problem, more the wish for another feature.

Outside the US most countries use the electronic symbols according to
the international standard set by the IEC. It would be great if it would
be possible to select the Symbols for resistor (
https://en.wikipedia.org/wiki/Resistor#/media/File:Resistor_symbol_IEC.svg
) and
lamp (
https://en.wikipedia.org/wiki/Electronic_symbol#/media/File:Lamp_symbol.svg
)

Ohterwise: You are doing a great job!
Thanks a lot!

@oliver-phet
Copy link
Author

Another reply from the original user:

Further to my email below, as the Wikipedia article suggests “The number of standards leads to confusion and errors” – indeed it does, hence my email.

Standard circuit symbols taught in UK schools can be found on page 24 of this examination board specification:

https://filestore.aqa.org.uk/resources/physics/specifications/AQA-8463-SP-2016.PDF

I’ve just loaded the PhET app to check which ones are the issue.

The British Standard 3939 contains these symbols, which I’ve snipped below:

https://www.sciencephoto.com/media/346763/view/standard-electrical-circuit-symbols

image

The confusing ones for UK students are just the light bulb and resistor (or anything else purporting to be a resistance, e.g. dollar bill (UK version could have five pound note!))

The addition of an LED and/or a diode to the circuit construction kit would be AMAZING.

I note that when in circuit symbol mode, any voltmeter and ammeter in the circuit remains represented by the orange coloured graphical representation, rather than changing to the standard A or V symbol in a circle. This would be a great feature please.

@samreid
Copy link
Member

samreid commented Jan 9, 2020

Co-assigning @ariel-phet since this might be a good task for Isam.

@samreid samreid self-assigned this Jan 9, 2020
@arouinfar
Copy link
Contributor

arouinfar commented Jan 9, 2020

1/9/20 design meeting

  • Options menu with radio buttons for IEEE & IEC, settable by query parameter e.g. ?schematic=ieee
  • @arouinfar will make a table of components in each style
  • Isam will likely be working with @samreid on this.

@arouinfar arouinfar self-assigned this Jan 9, 2020
@samreid
Copy link
Member

samreid commented Jan 13, 2020

Self-unassigning, please reassign me when the table of remaining components is ready.

@samreid samreid removed their assignment Jan 13, 2020
@arouinfar
Copy link
Contributor

@samreid @ariel-phet it looks like these are the primary differences in the IEEE and IEC standards.

Component IEEE IEC
Resistor & grab bag items image image
Bulb image image
Fuse image image

It seems like the coil-like inductor is a deprecated symbol, and IEEE and IEC both use the symbol currently in master. Both standards are behind a paywall, but CU has access to the IEEE standards. I've uploaded a copy of the IEEE standards to the CCK sim design folder.

@samreid
Copy link
Member

samreid commented Jan 17, 2020

@ariel-phet or @kathy-phet or @arouinfar is this feature (query parameter and in-sim option) important for next week's dev release?

@kathy-phet
Copy link

No - its not a priority.

@ariel-phet ariel-phet removed their assignment Jan 27, 2020
@oliver-phet
Copy link
Author

Another email received 3/10/2020:

I am a physics teacher from Slovenia and I am wondering if you are thinking of adding to your simulation the possibility of choosing electrical symbols for Europe, which differs in certain parts from US (lamp and resistor)?
https://phet.colorado.edu/sims/html/circuit-construction-kit-dc-virtual-lab/latest/circuit-construction-kit-dc-virtual-lab_en.html

My suggestion is that you could also add EU symbols to the picture below.
image
image

samreid added a commit that referenced this issue May 5, 2020
samreid added a commit that referenced this issue May 5, 2020
samreid added a commit that referenced this issue May 5, 2020
samreid added a commit that referenced this issue May 5, 2020
samreid added a commit that referenced this issue May 5, 2020
@samreid
Copy link
Member

samreid commented Mar 4, 2021

At today's design meeting, we agreed to go ahead with this. Let's do it as a cherry-pick maintenance release.

@samreid
Copy link
Member

samreid commented Mar 5, 2021

The proposed fix is in master, @arouinfar can you please test and verify? I'm also seeing some layout issues in the carousel in master--we will make sure those don't affect the branch.

@samreid samreid assigned arouinfar and unassigned samreid Mar 5, 2021
@arouinfar
Copy link
Contributor

arouinfar commented Mar 5, 2021

@samreid the schematics, Options dialog, and query parameter are all looking good in master.

I'm also seeing some layout issues in the carousel in master--we will make sure those don't affect the branch.

The carousel is looking pretty wacky right now. I'm seeing lots of holes. Should you publish an rc version on the 1.2 branch to verify before proceeding with the MR? (Or maybe just a dev version if you can do it on the 1.2 branch.)

@samreid
Copy link
Member

samreid commented Mar 5, 2021

Yes, we'll publish an RC for the MR.

@arouinfar
Copy link
Contributor

@oliver-phet can you forward me the user's email so I can let them know when we publish the maintenance release?

@arouinfar arouinfar assigned oliver-phet and samreid and unassigned arouinfar Mar 5, 2021
@samreid
Copy link
Member

samreid commented Mar 5, 2021

In phetsims/phetmarks#48 @jessegreenberg remarked that he is in the process of making a maintenance release--I'll need to coordinate with him.

@oliver-phet
Copy link
Author

User email forwarded.

@oliver-phet oliver-phet assigned arouinfar and unassigned oliver-phet Mar 5, 2021
samreid added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Mar 5, 2021
@samreid
Copy link
Member

samreid commented Mar 5, 2021

samreid added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Mar 5, 2021
@arouinfar
Copy link
Contributor

@samreid looks good!

@arouinfar arouinfar removed their assignment Mar 7, 2021
@samreid
Copy link
Member

samreid commented Mar 7, 2021

Deployed: https://phet.colorado.edu/sims/html/circuit-construction-kit-dc/latest/circuit-construction-kit-dc_en.html
Please wait for the build-server to complete the deployment, and then test!
After testing, let the simulation lead know it has been deployed, so they can edit metadata on the website

Deployed: https://phet.colorado.edu/sims/html/circuit-construction-kit-dc-virtual-lab/latest/circuit-construction-kit-dc-virtual-lab_en.html
Please wait for the build-server to complete the deployment, and then test!
After testing, let the simulation lead know it has been deployed, so they can edit metadata on the website

@arouinfar does any metadata need to be changed?

@samreid samreid assigned arouinfar and unassigned samreid Mar 7, 2021
@arouinfar
Copy link
Contributor

Everything's looking good and there wasn't any metadata to update. AP's also tweeted about the new feature a few times too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants