-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show edit hint on components from the tool box #181
Comments
@samreid can you address this before we deliver a new version to Stanford? I wouldn't be surprised if a few students figure out this unintentional hint. |
Fixed above and ready for review in next version. |
Testable version in #197 |
Looks good in 1.0.0-dev.22 |
Actually, something's not quite right here...
|
Thanks @arouinfar! |
In the preceding commit, the hint updates when the mode changes, and it seems to have the correct behavior for the scenario @arouinfar described above. Note that the hint does not appear for wires because they cannot be edited (though they can be deleted). Ready for review in next version. |
The test issue is #203 |
@arouinfar can you please test this in the version linked above? |
Looks good! |
Currently, in each Black Box challenge with a component in Reveal, the screen displays a "Tap circuit element to edit." hint. This is true for all challenges except challenge Black Box 2, which doesn't display a hint since Reveal only contains a wire. This could be a dead giveaway to some students; after I showed @arouinfar this, she proposed that the "Tap circuit element to edit." hint only appears/applies to components dragged from the tool box. This would effectively change each challenge to never display the hint without a user dropping their own component in the play area. The hint would go away when all user-placed components are removed.
Seen on Win 10 & OSX 10.11.5 Chrome. For phetsims/tasks#643.
The text was updated successfully, but these errors were encountered: