-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for when one circuit element dropped directly on top of another #117
Comments
👍 Additionally, components should not snap on top of one another. |
The solution I was envisioning is actually more complex than I anticipated, because we may need to search out a group of components from a pivot vertex and rotate the entire group around the point. |
Though rotating a subgroup about a vertex could come in handy elsewhere, such as rotating a group about a black box vertex. Though perhaps it would be prudent to start with a less complex solution for the simplest case (no group of connected components). |
Initial work in 016f377 |
After the commits above, the functionality seems to be in a good position. Next I'll do broader testing then publish a version for @arouinfar to take a closer look at. |
I fixed one new bug, and am seeing other problems related to the black box vertices--we'll have to tell them (a) it is always OK to attach to them despite other rules against it and (b) never to move them even if the postprocess step wants to. |
More fixes above, no new issues found during testing. I'll close this one and create a new issue for broader developer testing before sharing to @arouinfar. |
When one circuit element dropped directly on top of another, connect one vertex and move the other vertex. Should be done for wires too.
The text was updated successfully, but these errors were encountered: