Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for when one circuit element dropped directly on top of another #117

Closed
samreid opened this issue May 29, 2016 · 7 comments
Closed
Assignees

Comments

@samreid
Copy link
Member

samreid commented May 29, 2016

When one circuit element dropped directly on top of another, connect one vertex and move the other vertex. Should be done for wires too.

@samreid samreid self-assigned this May 29, 2016
@arouinfar
Copy link
Contributor

👍

Additionally, components should not snap on top of one another.

@samreid
Copy link
Member Author

samreid commented Jun 1, 2016

The solution I was envisioning is actually more complex than I anticipated, because we may need to search out a group of components from a pivot vertex and rotate the entire group around the point.

@samreid
Copy link
Member Author

samreid commented Jun 1, 2016

Though rotating a subgroup about a vertex could come in handy elsewhere, such as rotating a group about a black box vertex. Though perhaps it would be prudent to start with a less complex solution for the simplest case (no group of connected components).

@samreid
Copy link
Member Author

samreid commented Jun 2, 2016

Initial work in 016f377

samreid added a commit that referenced this issue Jun 3, 2016
samreid added a commit that referenced this issue Jun 3, 2016
samreid added a commit that referenced this issue Jun 3, 2016
samreid added a commit that referenced this issue Jun 3, 2016
@samreid
Copy link
Member Author

samreid commented Jun 3, 2016

After the commits above, the functionality seems to be in a good position. Next I'll do broader testing then publish a version for @arouinfar to take a closer look at.

@samreid
Copy link
Member Author

samreid commented Jun 3, 2016

I fixed one new bug, and am seeing other problems related to the black box vertices--we'll have to tell them (a) it is always OK to attach to them despite other rules against it and (b) never to move them even if the postprocess step wants to.

@samreid
Copy link
Member Author

samreid commented Jun 3, 2016

More fixes above, no new issues found during testing. I'll close this one and create a new issue for broader developer testing before sharing to @arouinfar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants