Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise Webstorm phet-info/ide/idea/phet-idea-codestyle.xml to include organizing imports and adding a file suffix #898

Closed
chrisklus opened this issue Feb 26, 2020 · 6 comments

Comments

@chrisklus
Copy link
Contributor

From meeting with @zepumph and @samreid.

@chrisklus
Copy link
Contributor Author

@zepumph will mark this for developer meeting after completing so we don't have someone forget to change their own xml.

@zepumph
Copy link
Member

zepumph commented Feb 26, 2020

Here is what we're thinking:

  • When comparing the checked in code style to mine it is a bit different, perhaps that is because I changed things, and maybe it is because the codestyle is a bit out of date.
  • We will want to add (at least) two things, auto sort imports, and make sure to include .js suffix (for windows. I'll brainstorm others.
  • I will try to do small commits as we go to update the codestyle xml.

@zepumph
Copy link
Member

zepumph commented Feb 27, 2020

@jbphet also found Editor -> General -> Auto Import which may be interesting (perhaps developer discretion). It is not, as far as I can see, part of the code style.

zepumph added a commit to phetsims/phet-info that referenced this issue Feb 27, 2020
@zepumph
Copy link
Member

zepumph commented Feb 27, 2020

Committed above. All devs using a jetbrains IDE should do one of the following to support proper es6 module imports:

  1. pull phet-info and import phet-code style again.
  2. In the settings go to Editor -> Code Style -> Javascript and make sure that the following three elements are checked under the "imports" tab:
  • Use file extension in module name
  • Sort imported members
  • Sort imported by modules

Happy coding!

@samreid
Copy link
Member

samreid commented Feb 28, 2020

@chrisklus made changes to this, marking for meeting:developer for PSA.

@zepumph zepumph removed their assignment Mar 4, 2020
@pixelzoom
Copy link
Contributor

3/5/20 dev meeting: PSA delivered, thanks! Closing.

samreid pushed a commit to phetsims/phet-info that referenced this issue Apr 23, 2022
samreid pushed a commit to phetsims/phet-info that referenced this issue Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants