Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 migration steps #875

Closed
jonathanolson opened this issue Feb 6, 2020 · 11 comments
Closed

ES6 migration steps #875

jonathanolson opened this issue Feb 6, 2020 · 11 comments

Comments

@jonathanolson
Copy link
Contributor

From the planning doc:

(2 hours, SR, ???) [pre-publication, sprintable] Migration step: Run the migration and modulify. We would agree as a team to a switchover moment.
There are likely repos that aren't in active-repos that we want to bring along for these changes, since the change may be so large that it would be hard to do so later.

Protein-synthesis

KP: I agree this should be migrated
Lift-challenge
Sugar and salt solutions
Any others not in https://github.com/phetsims/perennial/blob/c4cb9a0ef811436ac17f3901398739e15e6c8dc1/data/active-sims?
CM: faraday?
KP/AP: OK to test all stale repos and see if they migrate. If they migrate, great! Commit them! If not, then record chipper SHAs and save them for later.
The same though for "feature" or "development" branches, but release branches will need to stay the same. Maybe from a dev brainstorming meeting.
JO: If we migrate both master and the branch it could cause conflicts.
SR: Maybe the answer is to get everyone to organize their branches, and we will just migrate master.
SR: Let’s coordinate this date, so everyone is all set.
AP: Let’s create an issue, with correct label and mark for dev meeting.

@samreid
Copy link
Member

samreid commented Feb 7, 2020

Placing on hold until we are ready to run the migration step.

@samreid
Copy link
Member

samreid commented Feb 21, 2020

Pre-migrate checklist:

Local migrate

  • check that lint-everything is passing
  • check that aqua is passing or mostly passing (passing up to friction, with a buoyancy fail as usual)

During the migration

  • select auto-format for the changed files during commit. We determined that WebStorm optimize imports was doing well, so we also checked that.
  • commit a few repos at a time so machine is not overwhelmed
  • states-of-matter branch "serializeParticleState"

Post migrate checklist:

@kathy-phet
Copy link

Fine with me to go on Thursday.

@emily-phet
Copy link

Onward!

@samreid samreid changed the title ES6 migration and choosing repos to migrate ES6 migration steps Feb 27, 2020
samreid added a commit to phetsims/perennial that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/perennial that referenced this issue Feb 27, 2020
@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 27, 2020

shas for all active-repos, just before migration.

% pull-all.sh
% clone-missing-repos.sh
% print-shas.sh 
acid-base-solutions 8ad98a933669b21e9c8c403320efddad53fcc3e2
aqua ddd1f03e4513e4374461dfb1955853c13d36e188
area-builder 3630e650abf7a51dabc835ef6d3d4573b5a3f960
area-model-algebra 245f05c04803b4894bccd65dfc57b525bcb56b37
area-model-common 4d1fffd023f70b8ee9256d5d96de53b07b44a7ba
area-model-decimals db228740b0e21e95db47bf06d742ac1407f9630d
area-model-introduction f81754d8ac9b685f11fcd868a888e3813208bc14
area-model-multiplication 3bd072338e43977540afff528ded7136b9f2f669
arithmetic 62a818bf462b23cf1ee9f49f633532003b204b02
assert a99a9ce9ee0774bf3ef509bf3e31ca7383f67478
atomic-interactions b32858009c168654a409beffe5057d63e7ad70ee
axon e1c69917a9d4150daaa96126ccdf35ea02fff6b5
babel c0529e060903469003631345fd0849515df45883
balancing-act c5d4fbc4a211eae26d9dbe8bd73b183c8a9c098c
balancing-chemical-equations 52f42383aa0f9f1b8b6d357a9afccc521cda1067
balloons-and-static-electricity 7e32ab552300720e3c26aa22e797819b63c7bdb4
beers-law-lab 7d80c12a50bc2b63490e57798aba15376816910b
bending-light 1f08188e8e4d25671b971411ff67aea6f823907e
binder 0ae7182e11808a83abc37d4a6c45a8c30e47415e
blackbody-spectrum 6ac3c376c2f814f122e9d00e6159ad625f43e66b
blast 35e9665cb12044507df046540f47ced8dcacf83b
brand a7092888f84705cc5e6f38431682dfcfc29e9ebb
build-a-fraction 4ac34b0924d4b53b0e3df37a4b9a08dcde18d058
build-a-molecule 017df66bf74980fb10fc0283a98520ceff47a2d1
build-an-atom a05f64cca7e20a04404cfa88b5c1778cbff4706c
bumper 11b190dcaf81d5a7a18a24b3d2b1a3d79af5add0
buoyancy 83d9b1913ce01445de567dacfdaf02c3d1f47a48
calculus-grapher 1600fecca60022c289eac0b83faa6293db94f06d
capacitor-lab-basics 6c54a9fab1aeafcdfb941f1cea8827eddb50559b
chains d85346ebf43370bee25aae890015fbdc4aea93cd
charges-and-fields 61af5f120703544cbecf2e378ab685ecf893bf8e
chipper a690185705e1cd31703da7a82427ffa4cddc1f33
circuit-construction-kit-ac 2694215c10b445eb370bf70b4a7ac686e3cf9758
circuit-construction-kit-black-box-study 4c7f9745d655e22a5d56ddbf8b8ce65e11163330
circuit-construction-kit-common dafe04502eb6a0ef07853f4edc4e50e9479928a6
circuit-construction-kit-dc 513798aac2d2ad1f3d517b416b3190e674d9df93
circuit-construction-kit-dc-virtual-lab c2b6b0aa7fec9118445eb6dcdb938e773d6d54f1
collision-lab 66dcad675ab9f0fb344964456cd2445d402d7a63
color-vision 9eedf408444a59bcf73767aa1fa1787c1d8f2fff
concentration 415184a803fe1c325c01530d29ec4989d408f751
coulombs-law 7aa46fa533e4fae32ebdea113a7de18e3f41f804
curve-fitting 47a007443fee16e728fe7840d43217539bd74572
density 1234fd55d2072f79f4f6644240d14296b2b42db6
density-buoyancy-common aa5c0bcc9bc75cd8cbefd7790be9e785bfd72905
diffusion 46ddd6dfd6708c8a252f65cf3c32de22b6a6edeb
dot 98d15ec4ea5be402ed89d4d310e166f928688d62
energy-forms-and-changes 54b6fe6227ddde36ec3e43dff65be5e605197cd9
energy-skate-park d7a0945b8ffc5da0c693c663a45b2139d9a7aaa4
energy-skate-park-basics 7f0b34bb14bfc926cab9590074aa4b301e13d3b6
equality-explorer 2bcb79d879cb012e02c537e5dc401b38565a7a46
equality-explorer-basics e080107f1275f34e14d4820ea4f554bea130794a
equality-explorer-two-variables ab93a04045d7835886f907ef54ca50d22924e5ab
estimation 325c75f376c5446f3ab534a7e9767165acb98782
example-sim f282e06b9077ac7a0826b4714b78f5c11e06f367
expression-exchange 189d4bc47e5b9a453599153fe2266b13075ab1ed
faradays-law 330757da677df839807e17e2aaa2d81861b8673b
fluid-pressure-and-flow 63cd4e87f8e965af50b5b288f7063e88af2edd93
forces-and-motion-basics 513634e21ced61512d957cddc03c170829ab14eb
fraction-comparison 769d7c7e0dabe93365892315f405275f171bbad3
fraction-matcher 7de1c867a390178224496be3f120f29380018fc7
fractions-common b8d8a8724cb76c84a5abec5f4552281fe94abb30
fractions-equality 30dde0d7f2171b77fcaf0546f175b205221adeec
fractions-intro 65192244e1258c44d10416fe3b3430b42dbd8dd0
fractions-mixed-numbers a9150fe18080ff3bedfee47eb4ff9972d3a3972c
friction 962d066b15ffe690713dc4f9e860b509d9686895
function-builder 0157176ca7b4c214ed126cb22b18c3ed83509ff4
function-builder-basics 264062d9d436cfd164e79238e108b9c54e1778fa
gas-properties 28ebaf9cafbe33e9e018a6f36caa35cd9b64f15b
gases-intro be961bf3d76e5f680466922e9332aefa38764286
gene-expression-essentials 895e70c39d9b2f92521533d879506efafc6137ec
graphing-lines ca94564e26f6ab617297e6b0527ca4f92e090ade
graphing-quadratics aeef016ed442e8d0c8e1381fd5e751e0be3f0b3f
graphing-slope-intercept 2dd05c2f7e20cc80c3ac35d378fc2a5802baa29c
gravity-and-orbits 593524a7f809d74e85862d1cd12a392eb018e1f5
gravity-force-lab 501f0fa3deb73f24328d898192846006e1df2407
gravity-force-lab-basics aef25919bdffc72ab386a8cd00040e6612540391
griddle 6c71915d8681f88005fbc30f7dadc7e126768961
hookes-law 65a7821f65c473d3b0f92535baf423543f6667d6
installer-builder f3a2d09b6652fc3e249177f239c591557c99867d
interaction-dashboard 8024f24ddc8883a5db4f18aec40f7c71d4cffc4e
inverse-square-law-common 6fecaeeb1ccea4d1b897d704e9470d132e69fb19
isotopes-and-atomic-mass 75c050de15ab904fe6fb88253cf82c1180bef1f9
john-travoltage 46c86d8151e25bf59eedbe5ddbf48e22af209c70
joist 9355629939a9e9e730746f4a09cfeb2c9b56d753
kite e2d550155eb55f311b4583e13d94fdc8b0d7218c
least-squares-regression c30dd901a84d9341900f9ac5a29a05c475598400
make-a-ten 3197112707fba2e49f02158127490dc02c1981ac
masses-and-springs 2c5aa3d2b309a17fb2aee70f684a64b5e1c8ebbb
masses-and-springs-basics b8f5ef44356ec49d06d53e45b60812fecf8e3ac1
mobius 2859a6e44ee629a7f4b2799a0db698a2ae7710c2
models-of-the-hydrogen-atom 4fdee851bb034dbdb0e623b69da423b774fe7804
molarity 4aa98aec23f99a5bc409c865e11e31b8f5f0e352
molecule-polarity 9659981a95bfd81d0742593991aa665194c301c0
molecule-shapes 3157ed70ba6f7f756b52cfc768fc6e584694b19d
molecule-shapes-basics 23426b0c03cd6c0d28a8236c9395dd6fe3d5214a
molecules-and-light ca6b364d3f2fa19c1843cec4fea9311c5cbda7c8
natural-selection ea0d04b8705b4c1a6a1f49ed3f9b6f26599047db
neuron 7ff5c03c082cd193792872705d55da10b3ea9e03
nitroglycerin 1df9382e672418ab76b083d319dcbd3489ac2417
normal-modes 86971e09f96d1abd1bc1869636d001d19bd1702d
number-line-integers e20e8f8d41b7758dfd3fb9a6986c10df7c1b9458
number-play efe8ee4f90cbabda3372ae773c17e2ae8be50718
ohms-law e1e900c6c0934980cdd11aa6c1a489c6ecdddb29
optics-lab 0ad8f24dd0296795b57ebcbcacc70a735639f91f
pendulum-lab 72a8599fb1292b5cf70c9f45f94685189f03b51f
perennial 1029c511992a792d326391ecb92ba30b6cb92b64
ph-scale e32776106c3f43bd269c7a6dbff7ac9eba09a769
ph-scale-basics 2d7f16a1db8aa1095663af8064a20bd27accf8d7
phet-android-app 4ce5096edcbf706dbc175e745cb1aae1e81616ed
phet-core 95155ca8b04198a23bbd2e6e594afa9d11ad366e
phet-info 66b58839a6e717a3a31871abba33c124933f7a93
phet-io 3f5194b6add31c5c0838ba8007814b29df747848
phet-io-test-sim 4349788961767c0aacf420853ed55f32ab903fdc
phet-io-website f37658b727dcc7f501ee35c54228ac9467bd6e7c
phet-io-wrapper-arithmetic d01c60055ac4bf3e29078d164282be2b71299460
phet-io-wrapper-classroom-activity ba454bedf1e40ad889102b20ff9c421f4578175b
phet-io-wrapper-haptics fa84ebfa08c808df203f075d9545752ab1af7c56
phet-io-wrapper-hookes-law-energy 7817153e234cf71b07f169fbbdb2f29f27aaf22c
phet-io-wrapper-lab-book bf7a5e6ba610c38210431a9837ddbfaa01f1eb6a
phet-io-wrappers 633c1bee83189991244506213b6ad804d8827b87
phet-ios-app 49b0a075f7b3d46e484580c529c32096ace8b566
phetcommon 1d38ca56973a98e00503dc7b370bbc8eebef6b67
phetmarks db43be2d0af3017b222838ec92d2be72878201eb
plinko-probability e8c0cc7a10904b6b665b0c25cf9d35e5ad7f421d
projectile-motion af47929d2f022f9e579a908d1686150992bab116
proportion-playground 528658a498f240858453d0f11ca8a0fe62131077
query-string-machine d0435aa45cc13c17aa1c8c9c21882539123249db
reactants-products-and-leftovers c935c915bb6899c26f608e27904f4f8e348a3c3a
resistance-in-a-wire 95028c656d94c2553fbb59b3d15187a543af1c91
rosetta cf9f71caae1e52c40e2a260745f5a6746cf51714
rutherford-scattering 8d59524f674b490b85a86fa5a8c67646bc1db15e
scenery 25eb2c90b6067da9ece6d47327788769766b718c
scenery-phet 7247e438a20b4e92e5fa7ebbca8eca2e1a34d11b
sherpa 3e733a56f96762482e2360c692c5ac7ff43eb283
shred dfe5656220d21ac8e378636e1323b6124101e0ef
simula-rasa 9a0f5a1f78abe1cea7a0831ba2b6a9f45adead9c
smithers 5c264aab030d52888483e80bf5ee0e146f8c21a7
states-of-matter 14890e6d1b5c9d1b47c304f5bb7b819ce3569793
states-of-matter-basics 7dd874eec4c5968686b5b2411d8e0014301a4ef4
studio 6ef88cd75603c350a5010611acfe7fa5a3fb4fe6
sun 2eaea8dc679541db3e10a693fa04a8ccb8a099ee
tambo 3c6948a11a00124a94c985d8232cd4820b3b5dc0
tandem a67d85966f21dab17e126fb4b4ca27241a3ad720
tappi ec817842da775beb0cc0b26362fc69e94ecad3b3
tasks 894239e72bc98de5ed2f75452f538fcb5945c7fc
trig-tour da72de89a91b972b93119c64251cd4fd64f45474
twixt b6b758b7de1f2c8697e8bdbaa0c6f02734a84612
under-pressure 4d389595a32a1cbf1d1588e69236d0705ca86df7
unit-rates 523d2b209aaa40ca834b421cf8bf10af2599ccea
utterance-queue 0b22edb521ed4c0a5015c2a6f42020e836dad245
vector-addition 1ac6eeaf04a296de12ce62b92675f71f47241895
vector-addition-equations b67790fceda636369f5fd132a95acc8c8c03327c
vegas 056c8d4ed68c3c839c2e9ca7e39e5aba554313c8
vibe aaf2e6a571d4a0cf979ff2f844bf92aa6ee5dd82
wave-interference 082423135565bd343ba02f9ee4ebc26d63e5a2b1
wave-on-a-string 9626deb6d43552397344b83fb361b50c162dc6e3
waves-intro ecdeb37467f4b73d77f87db5d84db21e4d1ff8a3
wilder d2f1b9dc5a66b445222cf6df5d4ad8294c2e0ce4
yotta c46ab66cf533c811716dd5256d19fb0f82ecb5f2
%

samreid added a commit to phetsims/acid-base-solutions that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/acid-base-solutions that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/acid-base-solutions that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/balloons-and-static-electricity that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/area-model-multiplication that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/area-model-introduction that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/area-model-decimals that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/atomic-interactions that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/area-model-algebra that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/area-model-common that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/area-builder that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/arithmetic that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/axon that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/balancing-chemical-equations that referenced this issue Feb 27, 2020
samreid added a commit to phetsims/capacitor-lab-basics that referenced this issue Feb 27, 2020
jbphet added a commit to phetsims/resistance-in-a-wire that referenced this issue Jun 8, 2020
jbphet added a commit to phetsims/plinko-probability that referenced this issue Jun 8, 2020
jbphet added a commit to phetsims/gravity-force-lab that referenced this issue Jun 8, 2020
jbphet added a commit to phetsims/john-travoltage that referenced this issue Jun 8, 2020
jbphet added a commit to phetsims/ohms-law that referenced this issue Jun 8, 2020
jbphet added a commit to phetsims/molarity that referenced this issue Jun 8, 2020
jbphet added a commit to phetsims/friction that referenced this issue Jun 8, 2020
jbphet added a commit to phetsims/tambo that referenced this issue Jun 8, 2020
jbphet added a commit to phetsims/vegas that referenced this issue Jun 8, 2020
jbphet added a commit to phetsims/vibe that referenced this issue Jun 8, 2020
jbphet added a commit to phetsims/sun that referenced this issue Jun 8, 2020
samreid added a commit to phetsims/bamboo that referenced this issue Nov 23, 2020
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 22, 2021
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 22, 2021
SaurabhTotey pushed a commit to phetsims/number-line-common that referenced this issue May 12, 2021
chrisklus pushed a commit to phetsims/counting-common that referenced this issue Jun 4, 2021
chrisklus pushed a commit to phetsims/counting-common that referenced this issue Jun 4, 2021
zepumph pushed a commit to phetsims/scenery that referenced this issue Dec 15, 2021
samreid added a commit to phetsims/scenery-phet that referenced this issue Apr 9, 2022
samreid added a commit to phetsims/scenery-phet that referenced this issue May 16, 2022
marlitas pushed a commit to phetsims/scenery-phet that referenced this issue Jun 22, 2022
marlitas pushed a commit to phetsims/sun that referenced this issue Jun 28, 2022
samreid added a commit to phetsims/tambo that referenced this issue Oct 28, 2022
samreid added a commit to phetsims/scenery-phet that referenced this issue Oct 29, 2022
samreid added a commit to phetsims/scenery-phet that referenced this issue Oct 29, 2022
marlitas pushed a commit to phetsims/scenery-phet that referenced this issue Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants