fix lint errors caused by bad-sim-text.js

[zepumph]

from #728, there were 74 errors that were caused by adding bad-sim-text lint rule:

Here are the affected repos:

• acid-base-solutions @pixelzoom
• area-builder @jbphet
• arithmetic @jbphet
• balancing-act @jbphet
• balloons-and-static-electricity @jessegreenberg
• beers-law-lab @pixelzoom
• bending-light @samreid
• build-a-molecule @jonathanolson
• chipper @zepumph
• circuit-construction-kit-common @samreid
• curve-fitting @jonathanolson
• dot @jonathanolson
• energy-forms-and-changes @chrisklus (done by @pixelzoom)
• energy-skate-park @jessegreenberg
• faradays-law @jbphet
• forces-and-motion-basics @jessegreenberg
• gene-expression-essentials @jbphet
• interaction-dashboard @zepumph
• john-travoltage @samreid
• joist @jonathanolson
• kite (@zepumph isn't sure if there need to be converted or ignored, over to you @jonathanolson)
• models-of-the-hydrogen-atom @pixelzoom
• molarity @pixelzoom
• molecules-and-light @jessegreenberg
• neuron @jbphet
• optics-lab @zepumph
• ph-scale @pixelzoom
• phet-core @zepumph
• phetcommon @zepumph
• reactants-products-and-leftovers @pixelzoom
• scenery @jonathanolson
• scenery-phet @zepumph
• states-of-matter @jbphet
• sun @zepumph
• tambo @jbphet (fixed by @pixelzoom)

To fix this, one of three actions should occur:

1. Replace that usage with something else as the code review guidelines suggest.
2. ignore this error by following the strategy that done in phetsims/wave-interference@e2a72ce. Make sure that usages are well documented!!!!
3. Decide that the directory that the error occurs in doesn't belong being linted by sim specific lint rules, and add a .eslintrc.js file that specifies the correct lint rules, see chipper/eslint/README for more details.

To trigger there errors, got to chipper/eslint/sim_eslintrc.js and change the bad-sim-text rule to error (value of 2). Assigning all responsible devs for above sims. I assigned myself to common code repos because they may be less straightforward.

[zepumph]

Actually regarding number "2" above, there are two ways to ignore the rule, and since the rule is set up to apply to the whole file (not individual lines), I think I prefer cd675bd

I think we should have a vote attached to this comment; to vote add a reaction to this comment.

If you would like to use eslint-disable at the top of the file (cd675bd) add a heart to this comment.

If you would like to use // eslint-disable-line at the first line of code ( phetsims/wave-interference@e2a72ce) add a hooray to this comment.

EDIT: developer discretion sounds totally find for this too.

[pixelzoom]

My sims are fixed, all passing lint.

[zepumph]

The repos assigned to me are now completed.

[jbphet]

Works for me.

[jbphet]

I've fixed the sims for which I am the responsible developer and have committed the change to the 'bad-sim-text' value to turn on the stricter checking. I'll watch CT for the next hour or so to make sure it doesn't cause a bunch of failures.

[jbphet]

I'm not seeing any unusual failures on CT, so I think this can be closed. I'm going to assign it back to @zepumph since I think everything is done but would like someone who is more familiar with the issue to make sure I'm not missing anything.

[samreid]

If you would like to use eslint-disable at the top of the file (cd675bd) add a heart to this comment.

If you would like to use // eslint-disable-line at the first line of code ( phetsims/wave-interference@e2a72ce) add a hooray to this comment.

bad-text should be rewritten so that it can provide line-specific failures, then we can use eslint-disable-line in the correct places.

[pixelzoom]

Should this still be labeled for developer meeting? If so, what feedback do you want?

[zepumph]

bad-text should be rewritten so that it can provide line-specific failures, then we can use eslint-disable-line in the correct places.

lets talk over in #738

that and #728 are follow up issues. Closing