Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite bad-text so that it can provide line-specific failures #738

Closed
zepumph opened this issue Jan 31, 2019 · 1 comment
Closed

Rewrite bad-text so that it can provide line-specific failures #738

zepumph opened this issue Jan 31, 2019 · 1 comment
Assignees
@samreid

Comments

@zepumph
Copy link
Member

zepumph commented Jan 31, 2019

From #736

I'm unsure about how exactly to do this in a general way. Right now it just looks at the largest node as text and does an indexOf search on it.
@zepumph zepumph mentioned this issue Jan 31, 2019
Closed
35 tasks
@samreid samreid self-assigned this Jan 31, 2019
@samreid
Copy link
Member

samreid commented Dec 31, 2019

I believe this was addressed as part of #791, please reopen if that's incorrect.

@samreid samreid closed this as completed Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph