Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Median Arrow does not update with dynamic strings #349

Closed
marlitas opened this issue Jul 6, 2023 · 4 comments
Closed

Median Arrow does not update with dynamic strings #349

marlitas opened this issue Jul 6, 2023 · 4 comments

Comments

@marlitas
Copy link
Contributor

marlitas commented Jul 6, 2023

While working on #147 I noticed:
image

It seems this just requires another listener for when the bounds change. ManualConstraint might work here.

@matthew-blackman
Copy link
Contributor

matthew-blackman commented Jul 11, 2023

I can see two solutions to this:

  1. In InfoValuesNode, put the median arrow in the same parent as dataValuesContainer and position it relative to its parent. This way when the dataValuesContainer is shifted the arrow will be as well.
  2. Call update in InfoValuesNode if the dataValuesStringProperty changes.

Thoughts as to which of these would be better @marlitas, or if there is another way?

@marlitas
Copy link
Contributor Author

We addressed this with ManualConstraint and it's working really well, however we didn't feel great about creating a class property for medianValueNodes. Would like for @samreid to review.

@samreid
Copy link
Member

samreid commented Jul 17, 2023

@matthew-blackman and I reviewed this, and it is really great. @matthew-blackman will apply the same strategy in another spot in another issue.

@matthew-blackman
Copy link
Contributor

Closing and continuing data values work in #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants