Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info dialogs need to have better maxWidth for text #224

Closed
samreid opened this issue May 26, 2023 · 2 comments
Closed

Info dialogs need to have better maxWidth for text #224

samreid opened this issue May 26, 2023 · 2 comments

Comments

@samreid
Copy link
Member

samreid commented May 26, 2023

From #170, note that the number lines don't line up either.

image

@samreid
Copy link
Member Author

samreid commented Jun 8, 2023

It looks like this now.

Image

I'm not sure what the problem is with max width on the text. @matthew-blackman or @marlitas do you recall? If not, this issue can be closed.

@matthew-blackman
Copy link
Contributor

Text and layout on all info dialogs looks good with dynamic string length. There are remaining issues with specific components like #349, but we can continue that work in the related issues. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants