Skip to content

Commit

Permalink
Update TODOs, see #45
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Apr 22, 2023
1 parent 51cb3e4 commit b899da4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion js/common/model/CAVObjectType.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default class CAVObjectType extends EnumerationValue {
public static readonly DATA_POINT = new CAVObjectType( 1 );
public static readonly SOCCER_BALL = new CAVObjectType( 0.3 );

// TODO: This term is confusing because sometimes these are rendered as 'x' marks
// TODO: This term is confusing because sometimes these are rendered as 'x' marks. Check all usages--sometimes it is in a dot plot and sometimes a line plot
public static readonly DOT = new CAVObjectType( 0.127 );

public static readonly enumeration = new Enumeration( CAVObjectType );
Expand Down
6 changes: 1 addition & 5 deletions js/common/model/SoccerModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -311,11 +311,7 @@ export default class SoccerModel extends CAVModel {
this.timeWhenLastBallWasKickedProperty.reset();
this.ballPlayerMap.clear();
this.soccerPlayerGroup.clear();

// TODO: SR: super.clearData() is called multiple times from reset.
// SR: This could be split up, but in my opinion it is clear and safe. Maybe best to call it twice
super.clearData();

super.clearData(); // NOTE: clearData is called twice, but that's not a problem
this.populateSoccerPlayerGroup();
this.nextBallToKickProperty.value = this.createBall();
}
Expand Down
2 changes: 1 addition & 1 deletion js/common/view/CardNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export default class CardNode extends Node {
start: () => {
this.moveToFront();
},
// TODO-UX: This emits for dragging the leftmost card to the left
// TODO-UX: This emits for dragging the leftmost card to the left, see https://github.com/phetsims/center-and-variability/issues/150
drag: ( event, listener ) => this.dragDistanceEmitter.emit( Math.abs( listener.modelDelta.x ) )
} );
this.addInputListener( this.dragListener );
Expand Down

0 comments on commit b899da4

Please sign in to comment.