Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nucleons do not return to center after going from unstable --> stable #146

Closed
phet-steele opened this issue Mar 6, 2017 · 2 comments
Closed

Nucleons do not return to center after going from unstable --> stable #146

phet-steele opened this issue Mar 6, 2017 · 2 comments
Assignees
@phet-steele
Labels
dev:phet-io type:bug

Comments

@phet-steele
Copy link
Contributor

Labeling as "dev:phet-io" since I do not see this bug in any production version.

  1. From start, put two protons in the atom (any screen).
  2. Check Stable/Unstable.
  3. Take a proton out. The remaining proton will not be centered. Can happen with neutrons.

Easily seen with the center mark:
screen shot 2017-03-06 at 11 46 06 am

The phet-io reported values of that proton's position:
screen shot 2017-03-06 at 11 33 04 am

Seen on macOS 10.12.3 Chrome. For phetsims/tasks#792.
@phet-steele
Copy link
Contributor Author

phet-steele commented Mar 6, 2017 •
edited
Loading

@jbphet, interestingly, this is not fixed after a reset all, or taking everything out of the atom.

jbphet added a commit to phetsims/shred that referenced this issue Mar 10, 2017
@jbphet
fixed an issue where the nucleus offset wasn't being set back to zero…
02002fc 
… when transitioning from unstable to stable, see phetsims/build-an-atom#146
jbphet added a commit that referenced this issue Mar 10, 2017
@jbphet
fixed an issue where the nucleus offset wasn't being set back to zero…
cc1b084 
… when transitioning from unstable to stable, see #146
jbphet added a commit that referenced this issue Mar 10, 2017
@jbphet
updated SHA for shred to pick up some needed changes, see #144 and #146
08ec6c8
@jbphet jbphet mentioned this issue Mar 10, 2017
Closed
6 tasks
@jbphet jbphet assigned phet-steele and unassigned jbphet Mar 10, 2017
jbphet added a commit that referenced this issue Mar 10, 2017
@jbphet
fixed an issue where the nucleus offset wasn't being set back to zero…
032dd54 
… when transitioning from unstable to stable, see #146

(cherry picked from commit cc1b084)
@phet-steele
Copy link
Contributor Author

Fixed, thanks.

jbphet added a commit that referenced this issue Nov 14, 2020
@jbphet
removed dead code, see #219 and #146
c465642
@jbphet jbphet mentioned this issue Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phet-steele phet-steele

Labels
dev:phet-io type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @phet-steele