Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Magic Numbers" feature #87

Closed
zepumph opened this issue Jul 6, 2023 · 9 comments
Closed

Implement "Magic Numbers" feature #87

zepumph opened this issue Jul 6, 2023 · 9 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jul 6, 2023

Expanding from #61 and #46

@zepumph
Copy link
Member Author

zepumph commented Jul 13, 2023

From design meeting during 7/13. We would like to be a bit more subtle than the thick line in https://energyeducation.ca/simulations/build-a-nucleus/build-a-nucleus_en.html.

We like having something simple, with thicker lines and not special highlighting. @ariel-phet would like to mockup before we implement anything. Over to him.

@Luisav1
Copy link
Contributor

Luisav1 commented Jul 21, 2023

From meeting with @ariel-phet 7/20, we decided to try and add a checkbox which would increase the stroke width of those cells who have magic numbers. Maybe we might need another class too such that we can play with that stroke width live.

@Luisav1 Luisav1 assigned zepumph and Luisav1 and unassigned ariel-phet Jul 21, 2023
Luisav1 added a commit that referenced this issue Jul 21, 2023
@zepumph
Copy link
Member Author

zepumph commented Jul 24, 2023

Also, if we can prep for Thursday with a potential ability to play around with the style of the stroke live, that would be great. Perhaps making the borders thicker, or dashed, or a different color (etc). I'll take the lead.

@zepumph zepumph removed their assignment Jul 24, 2023
@zepumph
Copy link
Member Author

zepumph commented Jul 24, 2023

A couple of potentially talking points for next design:

Same color, thicker line width:
image

Slightly darker color:
image

Just for fun, a gradient:
image

There is another color profile Property to play with if you want to before design meeting:

nuclideChartBorderMagicNumberColorProperty

Ready for review.

@zepumph
Copy link
Member Author

zepumph commented Jul 26, 2023

  • This should also effect the zoomed in chart too.

@zepumph zepumph self-assigned this Jul 26, 2023
@zepumph zepumph removed their assignment Jul 26, 2023
@zepumph
Copy link
Member Author

zepumph commented Jul 26, 2023

And for the zoomed-in view:
image

zepumph added a commit that referenced this issue Jul 27, 2023
@zepumph
Copy link
Member Author

zepumph commented Jul 27, 2023

Today in design meeting, we made the color Yellow, like a highlight. From here @ariel-phet will confirm the perfect color in correlation with #83. Over to him.

@ariel-phet
Copy link
Contributor

@zepumph @Luisav1

Since I worked on the colors in #83 I think once those are implemented, this issue will be good to go.

@ariel-phet ariel-phet assigned zepumph and Luisav1 and unassigned ariel-phet Jul 30, 2023
zepumph added a commit that referenced this issue Jul 31, 2023
@zepumph
Copy link
Member Author

zepumph commented Jul 31, 2023

Implemented above. See #83 (comment)

@zepumph zepumph closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants