Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

?neutrons=1&protons=1 does not work #84

Closed
zepumph opened this issue Jul 5, 2023 · 2 comments
Closed

?neutrons=1&protons=1 does not work #84

zepumph opened this issue Jul 5, 2023 · 2 comments
Assignees
@zepumph @Luisav1

Comments

@zepumph
Copy link
Member

zepumph commented Jul 5, 2023

While working on the decay equation for #46, we get an assertion on startup
zepumph added a commit that referenced this issue Jul 6, 2023
@zepumph
kick off to next frame, #84
f04d765
@zepumph
Copy link
Member Author

zepumph commented Jul 6, 2023

I got the sim working by moving this logic to the next frame. Likely this is occurring because the supertype is adding particles before the subtype screen view have completed their setup. No matter, this still seems buggy to me. I also noticed that the positions are not correct, and animation still needs to occur. To me that is not the best implementation of these query parameters.

@zepumph zepumph mentioned this issue Jul 6, 2023
Closed
@zepumph
Copy link
Member Author

zepumph commented Jul 27, 2023

This is working pretty well, and over in #101 we are now using isConstructionCompleteProperty instead of a setTimeout. I am ready to close

@zepumph zepumph closed this as completed Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

@Luisav1 Luisav1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @Luisav1