Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query parameters for setting the proton and neutron count when the sim starts #57

Closed
Luisav1 opened this issue Sep 15, 2022 · 1 comment
Closed

Add query parameters for setting the proton and neutron count when the sim starts #57

Luisav1 opened this issue Sep 15, 2022 · 1 comment

Comments

@Luisav1
Copy link
Contributor

Luisav1 commented Sep 15, 2022

@chrisklus and I added these query parameters while working on #51 to make it easier to work on it.

My supervisor Jason and I talked about adding a way to control the nucleon counts with number inputs while the simulation is running, we may add that in the future later or instead of these query parameters.
Luisav1 added a commit that referenced this issue Sep 15, 2022
@Luisav1
Add query parameters for the nucleon counts. See #57.
ec6b64f
Luisav1 added a commit that referenced this issue Oct 14, 2022
@Luisav1
Factor out function that loads nucleons based on the query parameter.…
08d953e 
… See #57.
Luisav1 added a commit that referenced this issue Oct 14, 2022
@Luisav1
Factor out function that loads nucleons based on the query parameter.…
2ecc4e6 
… See #57.
Luisav1 added a commit that referenced this issue Oct 18, 2022
@Luisav1
Check if the protons and neutrons query parameters creates an invalid…
9ef694f 
… nuclide, and add a warning if so. See #57.
@Luisav1 Luisav1 mentioned this issue Oct 18, 2022
Closed
Luisav1 added a commit that referenced this issue Oct 18, 2022
@Luisav1
Add query parameters for the nucleon counts. See #57.
49904f8
Luisav1 added a commit that referenced this issue Oct 19, 2022
@Luisav1
Revert "Add query parameters for the nucleon counts. See #57."
3cb833d 
This reverts commit 49904f8.
Luisav1 added a commit that referenced this issue Oct 19, 2022
@Luisav1
Add query parameters for the nucleon counts. See #57.
d7ec3bf
Luisav1 added a commit that referenced this issue Oct 19, 2022
@Luisav1
Factor out function that loads nucleons based on the query parameter.…
d5b3db4 
… See #57.
Luisav1 added a commit that referenced this issue Oct 19, 2022
@Luisav1
Factor out function that loads nucleons based on the query parameter.…
4a3f4e3 
… See #57.
Luisav1 added a commit that referenced this issue Oct 19, 2022
@Luisav1
Check if the protons and neutrons query parameters creates an invalid…
b8f8859 
… nuclide, and add a warning if so. See #57.
@zepumph
Copy link
Member

zepumph commented Jul 6, 2023

Initial implementation was done here, and a bug or two that has come up since will be addressed over in #84. Closing

@zepumph zepumph closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @Luisav1