Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use VBox for contentNode in AvailableDecaysPanel #63

Closed
pixelzoom opened this issue Oct 21, 2022 · 5 comments
Closed

Use VBox for contentNode in AvailableDecaysPanel #63

pixelzoom opened this issue Oct 21, 2022 · 5 comments
Assignees
@Luisav1

Comments

@pixelzoom
Copy link
Contributor

In order to replace HSeparatorDeprecated with HSeparator, and just "in general"...

AvailableDecaysPanel.ts should use a VBox for its contentNode. VBox will handle the layout for you, as well as the resizing of the HSeparator. It current uses a Node for contentNode, with a bunch of manual layout that duplicates what VBox will handle.
@pixelzoom pixelzoom mentioned this issue Oct 21, 2022
Closed
29 tasks
@jbphet
Copy link
Contributor

jbphet commented Nov 9, 2022

I think this was put in the wrong repo, since AvailableDecaysPanel is a class in Build a Nucleus. I will transfer.

@jbphet jbphet transferred this issue from phetsims/blackbody-spectrum Nov 9, 2022
@jbphet
Copy link
Contributor

jbphet commented Nov 9, 2022

Assigning to @chrisklus in addition to @Luisav1, since they are the ones that are working on this sim. Unassigning myself.

@jbphet jbphet assigned chrisklus and unassigned jbphet Nov 9, 2022
@Luisav1 Luisav1 assigned marlitas and unassigned chrisklus Nov 11, 2022
Luisav1 added a commit that referenced this issue Nov 11, 2022
@Luisav1
Change contentNode from Rectangle to VBox. Use HSeparator instead of …
28bd2db 
…HSeparatorDeprecated. See #63.
@Luisav1
Copy link
Contributor

Luisav1 commented Nov 18, 2022

This was fixed in the commit above. Assigning to @marlitas for review.

@Luisav1 Luisav1 removed their assignment Nov 18, 2022
marlitas added a commit that referenced this issue Nov 28, 2022
@marlitas
Review comments, see: #63
7442407
@marlitas
Copy link
Contributor

Added a couple review comments in the above commit. Small things. The changes look great!

@marlitas marlitas assigned Luisav1 and unassigned marlitas Nov 28, 2022
Luisav1 added a commit that referenced this issue Dec 2, 2022
@Luisav1
Remove TODO and set separator.top instead of separator.centerY for co…
488f421 
…nsistency. See #63.
@zepumph
Copy link
Member

zepumph commented Jul 6, 2023

Comments addressed in 488f421. Closing

@zepumph zepumph closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luisav1 Luisav1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pixelzoom @jbphet @chrisklus @zepumph @marlitas @Luisav1