Skip to content

Commit

Permalink
Review comments, see: #63
Browse files Browse the repository at this point in the history
  • Loading branch information
marlitas committed Nov 28, 2022
1 parent b9f28e0 commit 7442407
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions js/decay/view/AvailableDecaysPanel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ class AvailableDecaysPanel extends Panel {

public constructor( model: DecayModel, options: AvailableDecaysPanelOptions ) {

// REVIEW: is this still needed?
// TODO: investigate why a rectangle is needed, why isn't the contentNode centered correctly with just a node?

// create and add the title
Expand Down Expand Up @@ -290,6 +291,8 @@ class AvailableDecaysPanel extends Panel {

// create and add the separator
const separator = new HSeparator( { stroke: '#CACACA' } );

// REVIEW: recommend changing this to separator.top so that it's consistent with how layout is being set among other components where top and bottom is mostly used.
separator.centerY = arrangedDecayButtonsAndIcons.bottom + SPACING;

// create and add the particle labels
Expand Down

0 comments on commit 7442407

Please sign in to comment.