Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass in only particleAtom.positition value to isNucleonInCaptureArea() #149

Closed
Luisav1 opened this issue Aug 18, 2023 · 3 comments
Closed

Pass in only particleAtom.positition value to isNucleonInCaptureArea() #149

Luisav1 opened this issue Aug 18, 2023 · 3 comments
Assignees
@Luisav1
Labels
status:ready-for-review

Comments

@Luisav1
Copy link
Contributor

Luisav1 commented Aug 18, 2023

From #112. Currently passing in entire particleAtom.
@Luisav1 Luisav1 self-assigned this Aug 18, 2023
@zepumph
Copy link
Member

zepumph commented Aug 18, 2023

I do not think this is necessary, see #152 (comment)

@zepumph
Copy link
Member

zepumph commented Aug 21, 2023

@Luisav1 and I discussed and are in agreement.

@zepumph zepumph closed this as completed Aug 21, 2023
zepumph added a commit that referenced this issue Aug 21, 2023
@zepumph
just pass in positionProperty, #149
b24efea
@zepumph
Copy link
Member

zepumph commented Aug 21, 2023

Just kidding, we liked @Luisav1's idea here, because it was so simple and much cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luisav1 Luisav1

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @Luisav1