Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in only extractParticle() function to emitNucleon #152

Closed
Luisav1 opened this issue Aug 18, 2023 · 2 comments
Closed

Pass in only extractParticle() function to emitNucleon #152

Luisav1 opened this issue Aug 18, 2023 · 2 comments

Comments

@Luisav1
Copy link
Contributor

Luisav1 commented Aug 18, 2023

From #112.

@Luisav1 Luisav1 self-assigned this Aug 18, 2023
@zepumph zepumph assigned zepumph and unassigned Luisav1 Aug 18, 2023
@zepumph
Copy link
Member

zepumph commented Aug 18, 2023

This is a reasonable thought, but I kinda think it is more trouble than it is worth. Much of the worry in regards to "only pass in what you need" is for class constructors, where by passing in a whole model class, you are more likely to use other stuff that further breaks encapsulation and muddy the exact purpose of your class. Here, it seems totally fine to provide a particleAtom to a function for extracting one of its particles.

I recommend closing this issue as a wontfix, but I'm happy to discuss further.

@zepumph
Copy link
Member

zepumph commented Aug 21, 2023

@Luisav1 and I discussed and are in agreement.

@zepumph zepumph closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants