Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust max width values to better support Arabic (and other) translations #124

Closed
jbphet opened this issue May 24, 2021 · 12 comments
Closed

Comments

@jbphet
Copy link
Contributor

jbphet commented May 24, 2021

@issamali67 has been working on translating this sim into Arabic, and ran into a few issues. He and I just met over Zoom and tried some modifications to his strings and were able to solve some of the problems that way, but there are two more changes that would help. They are:

  1. The Arabic words for Red, Green, and Blue all start with the same letter, so a single letter can't be used for the RGB display. When a full word is used, it ends up being quite small. If we can increase the width of these labels, the translation will look much better.
  2. The translation for the checkbox label "Graph Values" ends up being significantly longer in Arabic, so it would be helpful if the max width for this label could be increased.
@jbphet
Copy link
Contributor Author

jbphet commented May 24, 2021

I've committed changes for these two things. I believe that release branches are currently considered "locked down" based on what @jonathanolson said [in this comment]](phetsims/states-of-matter#354 (comment)), so I'll work with him on how to get these changes into a maintenance release.

@jonathanolson - How do I go about getting the two changes listed above into a maintenance release and when is it likely to go out?

@jbphet jbphet assigned jonathanolson and unassigned jbphet May 24, 2021
@jonathanolson
Copy link
Contributor

Is it a possibility for me to just roll those patches into the latest release branch and have them tested? I just put out RCs for maintenance (so we could also wait until that's fully handled).

@jonathanolson jonathanolson assigned jbphet and unassigned jonathanolson Jun 2, 2021
@jbphet
Copy link
Contributor Author

jbphet commented Jun 9, 2021

@jonathanolson - Yes, absolutely, you can roll these changes into the release branch and incorporate them into the next RC. Please let me know when you do and I'll double check them, but I think they are pretty straightforward.

@jonathanolson
Copy link
Contributor

Rolled into the maintenance release, cherry-picked above (needed manual changes for everything, please verify), and deployed an RC at https://phet-dev.colorado.edu/html/blackbody-spectrum/1.0.8-rc.3/phet/blackbody-spectrum_all_phet.html for testing.

@jonathanolson
Copy link
Contributor

Let me know if this looks ok?

@issamali67
Copy link

issamali67 commented Jun 10, 2021 via email

@KatieWoe
Copy link
Contributor

This was checked in phetsims/qa#656. Looks ok with both ?stringTest=rtl and ?stringTest=long

@jbphet
Copy link
Contributor Author

jbphet commented Jun 11, 2021

@issamali67 - You can't see the full effect on the Arabic translation from the RC version, but you can see how a single string would look in place of all strings. You and I did this when we met over Zoom and made adjustments. To do it, you use the query parameter stringTest=XX where the XX is whatever string you'd like to test. Here is a screenshot of the sim with stringTest=مخضر (which Google said was Arabic for "green"):

image

@jbphet
Copy link
Contributor Author

jbphet commented Jun 11, 2021

@jonathanolson - Yes, version 1.0.8-rc.3 looks good with respect to this issue, please feel free to move forward with publication.

@jbphet jbphet assigned jonathanolson and unassigned jbphet Jun 11, 2021
@jonathanolson
Copy link
Contributor

Sounds good, I'll be tracking it and will comment here once it's pushed out!

@issamali67
Copy link

issamali67 commented Jun 14, 2021 via email

@jonathanolson
Copy link
Contributor

Closing, handled in maintenance release deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants