Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency in concentrationMeterNode #308

Closed
arouinfar opened this issue Jan 11, 2023 · 2 comments
Closed

Missing dependency in concentrationMeterNode #308

arouinfar opened this issue Jan 11, 2023 · 2 comments

Comments

@arouinfar
Copy link
Contributor

For #296

Instances of labelText and valueText in the Studio tree usually link back to the associated StringProperty or dependencies. This is missing in *.concentrationScreen.view.concentrationMeterNode.bodyNode.valueText which seems like an oversight. @pixelzoom can you take a look?

Here's the current tree structure:
image

@pixelzoom
Copy link
Contributor

valueText.stringPropery is actually derived from 5 other Properties. Anyone who actually looks at this is likely to say "nevermind", so that's probably why I didn't instrument it. But it's instrumented now. Back to @arouinfar for review.

screenshot_2144

@arouinfar
Copy link
Contributor Author

valueText.stringPropery is actually derived from 5 other Properties. Anyone who actually looks at this is likely to say "nevermind", so that's probably why I didn't instrument it.

Oh, that makes sense now.

Back to @arouinfar for review.

Looks good in master, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants