Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhET-iO Design Review #296

Closed
arouinfar opened this issue Dec 7, 2022 · 2 comments
Closed

PhET-iO Design Review #296

arouinfar opened this issue Dec 7, 2022 · 2 comments
Assignees
@arouinfar
Labels
design:phet-io status:ready-for-review

Comments

@arouinfar
Copy link
Contributor

Related to #230

The most recent PhET-iO version of this simulation predates Studio and modern design practices. The tree should be thoroughly reviewed, so self-assigning.
@arouinfar arouinfar self-assigned this Dec 7, 2022
@pixelzoom pixelzoom mentioned this issue Dec 15, 2022
Closed
@pixelzoom
Copy link
Contributor

I've gone through the sim, and taken my "best guess" at revising the instrumentation for modern PhET-iO standards. @arouinfar this is ready for review.

@pixelzoom pixelzoom mentioned this issue Jan 3, 2023
Closed
This was referenced Jan 5, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@arouinfar
Copy link
Contributor Author

Design review is complete. All relevant issues are tagged above, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
design:phet-io status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @arouinfar