Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phetioFeatured overrides #305

Closed
arouinfar opened this issue Jan 9, 2023 · 3 comments
Closed

phetioFeatured overrides #305

arouinfar opened this issue Jan 9, 2023 · 3 comments
Assignees

Comments

@arouinfar
Copy link
Contributor

For #296

Opening an issue to track the commits.

@arouinfar arouinfar self-assigned this Jan 9, 2023
@pixelzoom
Copy link
Contributor

I confirmed with @arouinfar that she can commit the overrides.js file without breaking CT, because this sim does not yet have an API file. Ditto for concentration.

@arouinfar
Copy link
Contributor Author

I've committed a first pass at the phetioFeatured overrides. Next steps are to review in master and cleanup as needed, and then take care of Concentration.

@arouinfar
Copy link
Contributor Author

I reviewed the phetioFeatured overrides in BLL, found a few elements that slipped through the cracks and addressed in a161d4b. Then, I copied over all of the global and concentrationScreen overrides to Concentration (replacing beersLawLab with concentration), tested locally to make sure I didn't break anything with the replace all method. Everything looked okay, so I went ahead and committed to Concentration. Master looks fine to me, so I'm going to to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants