Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace grab/release sounds for the balloons or make them common #480

Closed
jbphet opened this issue Feb 2, 2021 · 6 comments
Closed

Replace grab/release sounds for the balloons or make them common #480

jbphet opened this issue Feb 2, 2021 · 6 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Feb 2, 2021

In the sound design document for this sim @Ashton-Morris suggested temporarily using the grab/release sounds that were used for the magnet in "Faraday's Law" as the sounds for picking up and release of the balloons. We would most likely replace these with something custom eventually.

I will copy these sound files over from Faraday's Law, but we won't have a corresponding asset in the assets directory. This GitHub issue is being opened so that we remember to either replace the sounds or, if we eventually decide we like them, move them to tambo and make them a shared resource.

@Ashton-Morris
Copy link

I have two sets of Balloon Grab and Release options ready to implement. Sounds for this sim will be stored here

  • balloon-grab-001.mp3
  • balloon-grab.mp3
  • balloon-release-001.mp3
  • balloon-release.mp3

@jbphet
Copy link
Contributor Author

jbphet commented Feb 9, 2021

The sound design team - @Ashton-Morris, @emily-phet, and me - tried these out in the sim during this week's sound design meeting, and we feel like something that is a little more cartoonish and not as realistic is what we're after. The magnet sounds (which are based on a wood block) that were previously used actually work fairly well in terms of being distinct, but are a little too "solid". So, and this is always challenging to capture in words, maybe something with the clarity of the wood block sounds but a bit more "airy".

@jbphet jbphet removed their assignment Feb 9, 2021
@Ashton-Morris
Copy link

Ashton-Morris commented Feb 15, 2021

I have created a few other options for us to try.

  • balloon-release-002.mp3
  • balloon-grab-002.mp3 (To be played quietly)
  • balloon-grab-003.mp3
  • balloon-release-003.mp3
  • balloon-release-004.mp3
  • balloon-grab-004.mp3
  • balloon-release-005.mp3
  • balloon-grab-005.mp3

@jbphet
Copy link
Contributor Author

jbphet commented Feb 16, 2021

These sounds were reviewed in the 2/16/2021 sound design meeting, and we decided to go with the 004 sounds from the list above. @Ashton-Morris heard a bit of distortions in the sounds, though, so he is going to try creating them again, and then we will integrate these sounds before giving them final approval.

@jbphet jbphet removed their assignment Feb 16, 2021
@Ashton-Morris
Copy link

I have cleaned the audio files and removed the distortion. They are labeled this

  • balloon-release-006.mp3
  • balloon-grab-006.mp3

@jbphet
Copy link
Contributor Author

jbphet commented Mar 2, 2021

These new sounds were integrated and then reviewed and approved in today's sound design meeting. Closing.

@jbphet jbphet closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants