Skip to content

Commit

Permalink
removed grab/release sounds that have been rule out, see #480
Browse files Browse the repository at this point in the history
  • Loading branch information
jbphet committed Feb 17, 2021
1 parent f1eb388 commit 0b9b579
Show file tree
Hide file tree
Showing 14 changed files with 3 additions and 183 deletions.
12 changes: 3 additions & 9 deletions js/balloons-and-static-electricity/view/BalloonNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,8 @@ import Rectangle from '../../../../scenery/js/nodes/Rectangle.js';
import SoundClip from '../../../../tambo/js/sound-generators/SoundClip.js';
import soundManager from '../../../../tambo/js/soundManager.js';
import Utterance from '../../../../utterance-queue/js/Utterance.js';
import grabBalloonSound from '../../../sounds/balloon-grab-002_mp3.js';
// import grabBalloonSound from '../../../sounds/balloon-grab-003_mp3.js';
// import grabBalloonSound from '../../../sounds/balloon-grab-004_mp3.js';
// import grabBalloonSound from '../../../sounds/balloon-grab-005_mp3.js';
import releaseBalloonSound from '../../../sounds/balloon-release-002_mp3.js';
// import releaseBalloonSound from '../../../sounds/balloon-release-003_mp3.js';
// import releaseBalloonSound from '../../../sounds/balloon-release-004_mp3.js';
// import releaseBalloonSound from '../../../sounds/balloon-release-005_mp3.js';
import grabBalloonSound from '../../../sounds/balloon-grab-004_mp3.js';
import releaseBalloonSound from '../../../sounds/balloon-release-004_mp3.js';
import balloonsAndStaticElectricity from '../../balloonsAndStaticElectricity.js';
import BASEA11yStrings from '../BASEA11yStrings.js';
import BASEQueryParameters from '../BASEQueryParameters.js';
Expand All @@ -53,7 +47,7 @@ const X_POSITIONS = PlayAreaMap.X_POSITIONS;

// constants
const grabBalloonKeyboardHelpString = BASEA11yStrings.grabBalloonKeyboardHelp.value;
const GRAB_RELEASE_SOUND_LEVEL = 0.2; // empirically determined
const GRAB_RELEASE_SOUND_LEVEL = 0.1; // empirically determined

class BalloonNode extends Node {

Expand Down
Binary file removed sounds/balloon-grab-002.mp3
Binary file not shown.
21 changes: 0 additions & 21 deletions sounds/balloon-grab-002_mp3.js

This file was deleted.

Binary file removed sounds/balloon-grab-003.mp3
Binary file not shown.
21 changes: 0 additions & 21 deletions sounds/balloon-grab-003_mp3.js

This file was deleted.

Binary file removed sounds/balloon-grab-005.mp3
Binary file not shown.
21 changes: 0 additions & 21 deletions sounds/balloon-grab-005_mp3.js

This file was deleted.

Binary file removed sounds/balloon-release-002.mp3
Binary file not shown.
21 changes: 0 additions & 21 deletions sounds/balloon-release-002_mp3.js

This file was deleted.

Binary file removed sounds/balloon-release-003.mp3
Binary file not shown.
21 changes: 0 additions & 21 deletions sounds/balloon-release-003_mp3.js

This file was deleted.

Binary file removed sounds/balloon-release-005.mp3
Binary file not shown.
21 changes: 0 additions & 21 deletions sounds/balloon-release-005_mp3.js

This file was deleted.

48 changes: 0 additions & 48 deletions sounds/license.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,4 @@
{
"balloon-grab-002.mp3": {
"text": [
"Copyright 2002-2020 University of Colorado Boulder"
],
"projectURL": "http://phet.colorado.edu",
"license": "contact [email protected]",
"notes": "created by Ashton Morris (PhET Interactive Simulations)"
},
"balloon-grab-003.mp3": {
"text": [
"Copyright 2002-2020 University of Colorado Boulder"
],
"projectURL": "http://phet.colorado.edu",
"license": "contact [email protected]",
"notes": "created by Ashton Morris (PhET Interactive Simulations)"
},
"balloon-grab-004.mp3": {
"text": [
"Copyright 2002-2020 University of Colorado Boulder"
Expand All @@ -23,30 +7,6 @@
"license": "contact [email protected]",
"notes": "created by Ashton Morris (PhET Interactive Simulations)"
},
"balloon-grab-005.mp3": {
"text": [
"Copyright 2002-2020 University of Colorado Boulder"
],
"projectURL": "http://phet.colorado.edu",
"license": "contact [email protected]",
"notes": "created by Ashton Morris (PhET Interactive Simulations)"
},
"balloon-release-002.mp3": {
"text": [
"Copyright 2002-2020 University of Colorado Boulder"
],
"projectURL": "http://phet.colorado.edu",
"license": "contact [email protected]",
"notes": "created by Ashton Morris (PhET Interactive Simulations)"
},
"balloon-release-003.mp3": {
"text": [
"Copyright 2002-2020 University of Colorado Boulder"
],
"projectURL": "http://phet.colorado.edu",
"license": "contact [email protected]",
"notes": "created by Ashton Morris (PhET Interactive Simulations)"
},
"balloon-release-004.mp3": {
"text": [
"Copyright 2002-2020 University of Colorado Boulder"
Expand All @@ -55,14 +15,6 @@
"license": "contact [email protected]",
"notes": "created by Ashton Morris (PhET Interactive Simulations)"
},
"balloon-release-005.mp3": {
"text": [
"Copyright 2002-2020 University of Colorado Boulder"
],
"projectURL": "http://phet.colorado.edu",
"license": "contact [email protected]",
"notes": "created by Ashton Morris (PhET Interactive Simulations)"
},
"carrier-000.wav": {
"text": [
"Copyright 2002-2020 University of Colorado Boulder"
Expand Down

0 comments on commit 0b9b579

Please sign in to comment.