Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Older sims failing when they expect Emitter.hasListener #355

Closed
jonathanolson opened this issue May 13, 2021 · 2 comments
Closed

Older sims failing when they expect Emitter.hasListener #355

jonathanolson opened this issue May 13, 2021 · 2 comments
Labels
dev:maintenance-release

Comments

@jonathanolson
Copy link
Contributor

This should ideally be patched out too.
@jonathanolson jonathanolson self-assigned this May 13, 2021
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding compatibility hasListener, see #355
ec0f621
jonathanolson added a commit to phetsims/acid-base-solutions that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/axon#355
5f6f2cb
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding compatibility hasListener, see #355
cbd62fd
jonathanolson added a commit to phetsims/arithmetic that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/axon#355
65b4839
jonathanolson added a commit that referenced this issue May 13, 2021
@jonathanolson
Adding compatibility hasListener, see #355
4eac9c1
jonathanolson added a commit to phetsims/hookes-law that referenced this issue May 13, 2021
@jonathanolson
updated dependencies.json for phetsims/axon#355
74327a6
@jonathanolson
Copy link
Contributor Author

Looks like it was mainly just arithmetic that was having a console failure. Failing in production. Should be patched up, unassigning for QA

@jonathanolson jonathanolson removed their assignment May 13, 2021
jonathanolson added a commit to phetsims/acid-base-solutions that referenced this issue May 14, 2021
@jonathanolson
Bumping version to 1.2.25-rc.1, phetsims/scenery#983, phetsims/joist#714
5e3c7b9 
, phetsims/axon#355
jonathanolson added a commit to phetsims/arithmetic that referenced this issue May 14, 2021
@jonathanolson
Bumping version to 1.0.25-rc.1, phetsims/scenery#983, phetsims/joist#714
18c7d37 
, phetsims/axon#355
jonathanolson added a commit to phetsims/hookes-law that referenced this issue May 14, 2021
@jonathanolson
Bumping version to 1.0.24-rc.1, phetsims/scenery#983, phetsims/joist#714
2dc132d 
, phetsims/axon#355
This was referenced May 14, 2021
Closed
Closed
jonathanolson added a commit to phetsims/acid-base-solutions that referenced this issue Jun 2, 2021
@jonathanolson
Bumping version to 1.2.25-rc.2, phetsims/scenery#983, phetsims/joist#714
11163f5 
, phetsims/axon#355, phetsims/joist#717
jonathanolson added a commit to phetsims/arithmetic that referenced this issue Jun 2, 2021
@jonathanolson
Bumping version to 1.0.25-rc.2, phetsims/scenery#983, phetsims/joist#714
974adc3 
, phetsims/axon#355, phetsims/joist#717
jonathanolson added a commit to phetsims/hookes-law that referenced this issue Jun 2, 2021
@jonathanolson
Bumping version to 1.0.24-rc.2, phetsims/scenery#983, phetsims/joist#714
1711267 
, phetsims/axon#355, phetsims/joist#717
@jonathanolson jonathanolson mentioned this issue Jun 2, 2021
Closed
jonathanolson added a commit to phetsims/hookes-law that referenced this issue Jun 10, 2021
@jonathanolson
Bumping version to 1.0.24-rc.3, phetsims/scenery#983, phetsims/joist#714
8d3ae26 
, phetsims/axon#355, phetsims/joist#717, phetsims/qa#653
jonathanolson added a commit to phetsims/acid-base-solutions that referenced this issue Jun 10, 2021
@jonathanolson
Bumping version to 1.2.25-rc.3, phetsims/scenery#983, phetsims/joist#714
bfabbe8 
, phetsims/axon#355, phetsims/joist#717, phetsims/qa#653
jonathanolson added a commit to phetsims/arithmetic that referenced this issue Jun 10, 2021
@jonathanolson
Bumping version to 1.0.25-rc.3, phetsims/scenery#983, phetsims/joist#714
d16abaf 
, phetsims/axon#355, phetsims/joist#717, phetsims/qa#653
@jonathanolson jonathanolson mentioned this issue Jun 10, 2021
Closed
jonathanolson added a commit to phetsims/acid-base-solutions that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.2.25, phetsims/scenery#983, phetsims/joist#714, p…
b92514f 
…hetsims/axon#355, phetsims/joist#717, phetsims/qa#653
jonathanolson added a commit to phetsims/arithmetic that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.0.25, phetsims/scenery#983, phetsims/joist#714, p…
dc2033f 
…hetsims/axon#355, phetsims/joist#717, phetsims/qa#653
jonathanolson added a commit to phetsims/hookes-law that referenced this issue Jun 17, 2021
@jonathanolson
Bumping version to 1.0.24, phetsims/scenery#983, phetsims/joist#714, p…
bb8288a 
…hetsims/axon#355, phetsims/joist#717, phetsims/qa#653
@jonathanolson
Copy link
Contributor Author

Closing, handled in maintenance release deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:maintenance-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonathanolson