Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ObservableArray to createObservableArray #336

Closed
samreid opened this issue Oct 2, 2020 · 3 comments
Closed

Migrate ObservableArray to createObservableArray #336

samreid opened this issue Oct 2, 2020 · 3 comments
Assignees
@samreid

Comments

@samreid
Copy link
Member

samreid commented Oct 2, 2020

From #330, it is time to convert all usages of ObservableArray to use the Proxy-based implementation createObservableArray. This will affect many repos.
@samreid samreid self-assigned this Oct 2, 2020
@samreid
Copy link
Member Author

samreid commented Oct 2, 2020

I completed the migration on my working copy. I ran the following checks:

  • Aqua fuzzing is passing
  • PhET-iO Aqua fuzzing is passing
  • Comparing the phet-io-api before/after for Energy Forms and Changes looks as expected (new elementAddedEmitter, elementRemovedEmitter, and removed ObservableArray events and methods).
  • I tested energyFormsAndChanges.introScreen.model.air.energyChunkWanderControllers.lengthProperty in studio and saw that it incremented as expected.
  • Lint-everything is passing.
  • Studio=>Launch seemed OK for Energy Forms and Changes
  • Natural Selection state wrapper seems operational

I'll commit shortly.

samreid added a commit to phetsims/area-builder that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
ecac50b 
…etsims/axon#336
samreid added a commit to phetsims/balancing-act that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
ff7564f 
…etsims/axon#336
samreid added a commit to phetsims/bending-light that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
df1cf30 
…etsims/axon#336
samreid added a commit to phetsims/build-a-molecule that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
5313d11 
…etsims/axon#336
samreid added a commit to phetsims/charges-and-fields that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
1b6a525 
…etsims/axon#336
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
e64dca8 
…etsims/axon#336
samreid added a commit to phetsims/curve-fitting that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
2e41390 
…etsims/axon#336
samreid added a commit to phetsims/density-buoyancy-common that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
cfeaf76 
…etsims/axon#336
samreid added a commit to phetsims/energy-forms-and-changes that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
623284d 
…etsims/axon#336
samreid added a commit to phetsims/energy-skate-park that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
739c52f 
…etsims/axon#336
samreid added a commit to phetsims/equality-explorer that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
cba757f 
…etsims/axon#336
samreid added a commit to phetsims/expression-exchange that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
2a07812 
…etsims/axon#336
samreid added a commit to phetsims/fluid-pressure-and-flow that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
fb33c94 
…etsims/axon#336
samreid added a commit to phetsims/forces-and-motion-basics that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
002e9ec 
…etsims/axon#336
samreid added a commit to phetsims/fourier-making-waves that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
576f275 
…etsims/axon#336
samreid added a commit to phetsims/fractions-common that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
0ef91c2 
…etsims/axon#336
samreid added a commit to phetsims/gene-expression-essentials that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
327ef48 
…etsims/axon#336
samreid added a commit to phetsims/graphing-lines that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
48926a3 
…etsims/axon#336
samreid added a commit to phetsims/isotopes-and-atomic-mass that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
4304497 
…etsims/axon#336
samreid added a commit to phetsims/joist that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
134ad0c 
…etsims/axon#336
samreid added a commit to phetsims/least-squares-regression that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
33e5218 
…etsims/axon#336
samreid added a commit to phetsims/make-a-ten that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
0a7f714 
…etsims/axon#336
samreid added a commit to phetsims/molecules-and-light that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
9c36030 
…etsims/axon#336
samreid added a commit to phetsims/neuron that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
e0c519a 
…etsims/axon#336
samreid added a commit to phetsims/number-line-common that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
4d6dd7c 
…etsims/axon#336
samreid added a commit to phetsims/number-line-integers that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
6fab5a8 
…etsims/axon#336
samreid added a commit to phetsims/number-line-operations that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
7faff12 
…etsims/axon#336
samreid added a commit to phetsims/number-play that referenced this issue Oct 2, 2020
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
5deb835 
…etsims/axon#336
samreid added a commit to phetsims/graphing-lines that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
eb68075
samreid added a commit to phetsims/graphing-quadratics that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
eaa700e
samreid added a commit to phetsims/isotopes-and-atomic-mass that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
a5a9650
samreid added a commit to phetsims/make-a-ten that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
071b789
samreid added a commit to phetsims/molecules-and-light that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
9c3d5e4
samreid added a commit to phetsims/natural-selection that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
faa0a8b
samreid added a commit to phetsims/number-line-common that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
b941c55
samreid added a commit to phetsims/number-line-operations that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
515bcb0
samreid added a commit to phetsims/number-play that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
766cdce
samreid added a commit to phetsims/optics-lab that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
9739760
samreid added a commit to phetsims/phet-info that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
fe42c3d
samreid added a commit to phetsims/projectile-motion that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
890e7cd
samreid added a commit to phetsims/proportion-playground that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
90b8f67
samreid added a commit to phetsims/scenery that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
d5389b2
samreid added a commit to phetsims/shred that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
870675a
samreid added a commit to phetsims/states-of-matter that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
238d1af
samreid added a commit to phetsims/tambo that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
9394b3e
samreid added a commit to phetsims/vector-addition that referenced this issue Oct 2, 2020
@samreid
Update documentation, see phetsims/axon#336
7282a61
@samreid
Copy link
Member Author

samreid commented Oct 2, 2020

CT didn't reveal any errors that seem related to this, closing.

@samreid samreid closed this as completed Oct 2, 2020
This was referenced Oct 5, 2020
Closed
Closed
Closed
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
@samreid @jessegreenberg
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
e02db4e 
…etsims/axon#336
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
@samreid @jessegreenberg
Update documentation, see phetsims/axon#336
83012f3
jessegreenberg pushed a commit to phetsims/greenhouse-effect that referenced this issue Apr 21, 2021
@samreid @jessegreenberg
Update documentation, see phetsims/axon#336
5fd80ae
chrisklus pushed a commit to phetsims/counting-common that referenced this issue Jun 4, 2021
@samreid @chrisklus
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
43b3838 
…etsims/axon#336
chrisklus pushed a commit to phetsims/counting-common that referenced this issue Jun 4, 2021
@samreid @chrisklus
Update documentation, see phetsims/axon#336
ee79121
samreid added a commit to phetsims/phet-info that referenced this issue Apr 23, 2022
@samreid
Migrate from ObservableArray => createObservableArray (Proxy), see ph…
2f73ada 
…etsims/axon#336
samreid added a commit to phetsims/phet-info that referenced this issue Apr 23, 2022
@samreid
Update documentation, see phetsims/axon#336
02e3379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samreid