-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad Memory Leak #72
Comments
With published version: |
@jbphet requested the test be done on recently published States of Matter. |
I did a memory analysis and found the leaks. There were three nodes for which there were no dispose functions, so they have been added. Kinda a lame of me to have missed these, but it's great that QA ran this test and identified the problem. Running a RequireJS version of Atomic Interactions, I now see the following memory heap size:
This is a pretty reasonable profile. The memory is increasing very gradually, and decreases between minutes 5 and 6, and holds steady between minutes 9 and 10. I did some comparisons between the heap snapshots, and there was nothing obvious from the sim that was leaking. If there is a slow leak, it's probably somewhere in common code, and it's not enough to cause any problems. Bottom line: I think this is now fixed. |
… and HandNode, see phetsims/atomic-interactions#72 and #237 (cherry picked from commit ef6ccc5)
For phetsims/qa#216
Start: 17.5 MB
1 min: 128 MB
2 min: 231 MB
3 min: 334 MB
4 min: 441 MB
5 min: crash before heap snapshot can finish.
Will try test on published version per request of @jbphet
The text was updated successfully, but these errors were encountered: