Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Sep 14, 2023
1 parent 5fa8c03 commit 3d7b46e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions js/common/view/PerimeterShapeNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,11 @@ class PerimeterShapeNode extends Node {
dimensionLabel.visible = true;
dimensionLabel.string = segmentLabelInfo.unitLength;
const labelPositionOffset = new Vector2( 0, 0 );
//TODO https://github.com/phetsims/kite/issues/3 At the time of this writing there is an issue with Shape.containsPoint() that can make
//TODO https://github.com/phetsims/area-builder/issues/127
// At the time of this writing there is an issue with Shape.containsPoint() that can make
// containment testing unreliable if there is an edge on the same line as the containment test. As a
// workaround, the containment test offset is tweaked a little below. Once this issue is fixed, the
// label offset itself can be used for the test.
// label offset itself can be used for the test. See https://github.com/phetsims/kite/issues/3
let containmentTestOffset;
if ( segmentLabelInfo.edgeAngle === 0 || segmentLabelInfo.edgeAngle === Math.PI ) {
// Label is on horizontal edge, so use height to determine offset.
Expand Down

0 comments on commit 3d7b46e

Please sign in to comment.