Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Sep 14, 2023
1 parent 928ffd6 commit 5fa8c03
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion js/common/model/ShapePlacementBoard.js
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ class ShapePlacementBoard {
return ( listener.shapePlacementBoard && listener.shapePlacementBoard === this );
}

// TODO: This is rather ugly. Work with SR to improve or find alternative, or to bake into Axon. Maybe a map. https://github.com/phetsims/tasks/issues/1129
//TODO https://github.com/phetsims/area-builder/issues/127 This is rather ugly. Work with SR to improve or find alternative, or to bake into Axon. Maybe a map.
// @private, remove all observers from a property that have been tagged by this shape placement board.
removeTaggedObservers( property ) {
const taggedObservers = [];
Expand Down
4 changes: 2 additions & 2 deletions js/common/view/PerimeterShapeNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,10 @@ class PerimeterShapeNode extends Node {
dimensionLabel.visible = true;
dimensionLabel.string = segmentLabelInfo.unitLength;
const labelPositionOffset = new Vector2( 0, 0 );
// TODO: At the time of this writing there is an issue with Shape.containsPoint() that can make https://github.com/phetsims/tasks/issues/1129
//TODO https://github.com/phetsims/kite/issues/3 At the time of this writing there is an issue with Shape.containsPoint() that can make
// containment testing unreliable if there is an edge on the same line as the containment test. As a
// workaround, the containment test offset is tweaked a little below. Once this issue is fixed, the
// label offset itself can be used for the test. See https://github.com/phetsims/kite/issues/3.
// label offset itself can be used for the test.
let containmentTestOffset;
if ( segmentLabelInfo.edgeAngle === 0 || segmentLabelInfo.edgeAngle === Math.PI ) {
// Label is on horizontal edge, so use height to determine offset.
Expand Down

0 comments on commit 5fa8c03

Please sign in to comment.