Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Snapshot comparison to compare description and voicing implementations #127

Open
zepumph opened this issue Aug 3, 2021 · 6 comments
Open

Use Snapshot comparison to compare description and voicing implementations #127

zepumph opened this issue Aug 3, 2021 · 6 comments

Comments

@zepumph
Copy link
Member

zepumph commented Aug 3, 2021

Basically a new strategy for phetsims/perennial#138. I would like to see if we can use the snapshot comparison to handle description comparison as well.
@zepumph zepumph self-assigned this Aug 3, 2021
This was referenced Aug 3, 2021
Closed
Closed
Closed
Closed
zepumph added a commit to phetsims/utterance-queue that referenced this issue Aug 3, 2021
@zepumph
add comparison of description alerts, and fix compareDescription quer…
68402d0 
…y parameter, phetsims/aqua#127
zepumph added a commit that referenced this issue Aug 3, 2021
@zepumph
shut off valve with query parameter, #127
ce3e0bf
zepumph added a commit that referenced this issue Aug 3, 2021
@zepumph
add comparison of description alerts, and fix compareDescription quer…
6d78760 
…y parameter, #127
@zepumph
Copy link
Member Author

zepumph commented Aug 3, 2021

I decided to commit to a branch for now, but I'm feeling pretty good about this. In general the logic is not too complicated. The hardest part is figuring out how to display the info well. I can't find a good HTML visual differ, so I ended up just setting up to easily be able to copy into webstorm to diff the PDOM. I'll come back soon, and will be using this for Friction too. Wahoo!

@zepumph zepumph mentioned this issue Aug 7, 2021
Closed
zepumph added a commit that referenced this issue Aug 7, 2021
@zepumph
keep the loop through frames going, #127
0f55040
@zepumph
Copy link
Member Author

zepumph commented Aug 7, 2021

Above is a bug fix where I wasn't continuing the looping function any time that the screenshots didn't differ.

zepumph added a commit that referenced this issue Aug 8, 2021
@zepumph
add voicing utterances support, #127
0309c0e
@zepumph
Copy link
Member Author

zepumph commented Aug 8, 2021

Added voicing utterance support above.

@zepumph
Copy link
Member Author

zepumph commented Aug 11, 2021

I showed @jessegreenberg these changes, and he liked them. He recommended turning the PDOM texts into buttons that will copy them to the clipboard. I like it!

Perhaps merging to master is coming soon.

@zepumph
Copy link
Member Author

zepumph commented Sep 1, 2021

I'm ready to merge this to master, even before this is done. Coming in hot!

@zepumph
Copy link
Member Author

zepumph commented Sep 1, 2021

Merged.

@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph