Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot comparison to support non screenshot comparison methods #125

Closed
zepumph opened this issue Aug 3, 2021 · 2 comments
Closed

Snapshot comparison to support non screenshot comparison methods #125

zepumph opened this issue Aug 3, 2021 · 2 comments

Comments

@zepumph
Copy link
Member

zepumph commented Aug 3, 2021

Over in phetsims/perennial#138, I want to compare PDOM description between two versions, and I feel like snapshot comparison could easily be build up to do that. First it will require a couple of minor changes to how the messages are formatted, and some terminology changes so that it isn't so based on "screenshots". Basically I'm thinking that a "snapshot" is just one load of the sim, in which N fuzzing steps occur, and data is taken in between each one. That data to me is a "frame," in which a screenshot is captured, but potentially other data too. Then an entire "snapshot" is also hashed all together. I'm going to commit what's in my working copy for review and discussion.

Also noting that other improvements may come out of #122 along the way.

Tagging @jonathanolson to note that I'm working in snapshot comparison at this time.

@zepumph
Copy link
Member Author

zepumph commented Aug 3, 2021

This is enough of a start to get going on #127. @jonathanolson does this commit seems reasonable to you?

@jonathanolson
Copy link
Contributor

Sounds perfectly reasonable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants