Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboardHelpDialog to binder #195

Closed
zepumph opened this issue Mar 13, 2024 · 1 comment
Closed

Add keyboardHelpDialog to binder #195

zepumph opened this issue Mar 13, 2024 · 1 comment
Assignees
@zepumph
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Mar 13, 2024

From #166, I was interested in how easy this would be. I think I'm at a commit point, so I'll see how the run over night goes.
@zepumph zepumph self-assigned this Mar 13, 2024
zepumph added a commit to phetsims/binder that referenced this issue Mar 13, 2024
@zepumph
Add KeyboardHelpDialog to binder, phetsims/a11y-research#195
be9cf6d 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/sun that referenced this issue Mar 13, 2024
@zepumph
Add KeyboardHelpDialog to binder, phetsims/a11y-research#195
f253830 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/joist that referenced this issue Mar 13, 2024
@zepumph
Add KeyboardHelpDialog to binder, phetsims/a11y-research#195
7c087ba 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/binder that referenced this issue Mar 14, 2024
@zepumph
move header to nav for easier scrolling, phetsims/a11y-research#195
363829c 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/binder that referenced this issue Mar 14, 2024
@zepumph
support loading hash links, phetsims/a11y-research#195
133fdaa 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit to phetsims/binder that referenced this issue Mar 14, 2024
@zepumph
add phet logo, phetsims/a11y-research#195
55c05cf 
Signed-off-by: Michael Kauzmann <[email protected]>
@zepumph
Copy link
Member Author

zepumph commented Mar 14, 2024

This is now live: https://phetsims.github.io/binder/#joist-KeyboardHelpDialog

@zepumph zepumph closed this as completed Mar 14, 2024
zepumph added a commit to phetsims/binder that referenced this issue Mar 14, 2024
@zepumph
a bit more spacing, phetsims/a11y-research#195
b218797 
Signed-off-by: Michael Kauzmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph